Page MenuHomePhabricator

Second sequential edit raises warning
Closed, DeclinedPublic

Description

Steps to reproduce

  1. Edit page with VE and add {{fact}}, and save page with VE.
  2. Wait until a bot adds parameters to {{fact}}
  3. Click 'Edit', starting the VE.

(I suspect that step 2 is not a mandatory part of the process)

Result:
Red warning with text that can not be copied: "You are editing an old revision of this page. If you save it, any changes since then will be lost."

The warning can be dismissed.

The 'Edit' button at the top of the page does nothing. Control-clicking 'Edit' in Firefox does open VE in a new tab.

(There is no apparent option to get a current revision of the page)

Expected result 1:
As the user has not started editing yet, they should be offered the option of starting editing again.

Expected result 2:
MediaWiki has edit conflict resolution, both manual (view diff and edit) and automated. The VE warning should not "If you save it, any changes since then will be lost." It should politely inform the user that they will need to merge those "any changes" into the new revision before saving. And the VE should give them a nice pretty interface to help them resolve the conflicts (and a unicorn too).


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=50441

Details

Reference
bz50716

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:11 AM
bzimport added a project: VisualEditor.
bzimport set Reference to bz50716.

Created attachment 12750
Screenshot of warning

Attached:

VE-edit-warning-walla.png (228×770 px, 24 KB)

I think the message "You are editing an old revision of this page. If you save it, any changes since then will be lost." is provided by a English Wikipedia message.

The message also appears when intentionally editing an old revision
(e.g. https://en.wikipedia.org/w/index.php?title=Walla!&action=edit&oldid=446460629)

Sorry to add what is probably also another existing bug:
Clicking edit on an old revision launches VE with the current revision rather than the specified revision.
i.e. goto https://en.wikipedia.org/w/index.php?title=Walla!&oldid=446460629 and click 'Edit'

The problem has been fixed. Cant be bothered finding the bug it was fixed under.