Page MenuHomePhabricator

VisualEditor: ./ inserted at the start of wikilinks when using Firefox 13 and 14, so we can unblacklist them
Closed, ResolvedPublic0 Estimated Story Points

Details

Reference
bz50720

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:42 AM
bzimport set Reference to bz50720.
  • Bug 50539 has been marked as a duplicate of this bug. ***

(In reply to comment #1)

Escalating priority. Additional example:

https://en.wikipedia.org/w/index.
php?title=OMICS_Publishing_Group&curid=35277259&diff=562944992&oldid=56157968
0

I can't reproduce this, and can in fact edit the page just fine: https://en.wikipedia.org/w/index.php?title=OMICS_Publishing_Group&diff=563024944&oldid=562947045

This bug must have some particularly nasty cache persistence properties; we've purged the Parsoid caches but that doesn't seem to have made it go away.

I think it might be to do with having punctuation in the links in this edit
https://en.wikipedia.org/w/index.php?title=Soccer_in_the_United_States&diff=prev&oldid=563041224
this the links which have ' or ( in them which get mangled other links are ok so
[[United States men's national soccer team|men's national team]] gets changed to
[[./United_States_men's_national_soccer_team|men's national team]] but [[FIFA World Cup|World Cup]] is unchanged. And [[National Professional Soccer League (1967)|National Professional Soccer League]] is changed to [[./National_Professional_Soccer_League_(1967)|National Professional Soccer League]].

Confirmed in Firefox 14. Steps to reproduce:

  1. Open https://en.wikipedia.org/wiki/HELLP_syndrome?veaction=edit as a logged in user
  1. Make an unrelated edit
  1. Press "Save" and "Review your changes".

The link [[Right upper quadrant (abdomen)|right upper quadrant]] is transformed to [[./Right_upper_quadrant_(abdomen)|right upper quadrant]].

Can reproduce in Firefox 13 and 14; cannot reproduce in 15 or 17 or 20. Interestingly in Firefox 13 I get a little bit more normalization in the diff as well. Looks like we get more progressively more broken the further down we go. :P

Change 72675 had a related patch set uploaded by Jforrester:
Blacklist Firefox 13 and 14 too

https://gerrit.wikimedia.org/r/72675

Change 72675 merged by jenkins-bot:
Blacklist Firefox 13 and 14 too

https://gerrit.wikimedia.org/r/72675

We believe that this should not recur due to the (hopefully-temporary) blacklisting of Firefox 13 and 14, which is now live in production. Consequently, I'm marking this bug as fixed. Please re-open if you find it happening again.

I think you viewed this bug solely as a blocker to bug 50848. I agree that it no longer is, but I don't believe this bug is now resolved/fixed. The issue hasn't been fixed, as I understand it, just worked around. I'm re-opening the bug, but removing bug 50848 as a blocker, lowering the importance fields, and clarifying the bug summary.

(In reply to comment #11)

I think you viewed this bug solely as a blocker to bug 50848. I agree that it
no longer is, but I don't believe this bug is now resolved/fixed. The issue
hasn't been fixed, as I understand it, just worked around. I'm re-opening the
bug, but removing bug 50848 as a blocker, lowering the importance fields, and
clarifying the bug summary.

Well, had you given me more than 30 seconds I was in the middle of creating a new bug, but never mind. :-) Repurposing this one.

Just wondering, has anybody tested VE on those old Firefoxes somewhat recently? The codebase is changing so fast this might as well be magically fixed now.

Should this task just be closed? I don't think anyone is going to put work into supporting these really old Firefox versions.

Jdforrester-WMF lowered the priority of this task from Low to Lowest.Mar 31 2016, 8:38 AM

Should this task just be closed? I don't think anyone is going to put work into supporting these really old Firefox versions.

I've been keeping this open as we would accept any patch doing this. Yes, there are relatively very few users, but it's not great to leave these users without an editor over something that's effectively trivial.

Esanders claimed this task.
Esanders subscribed.

Can no longer reproduce the test case given by Erik in FF13/14. Edited the link directly to avoid SelSer.

https://en.wikipedia.org/wiki/HELLP_syndrome?veaction=edit&vewhitelist=1

pasted_file (867×1 px, 625 KB)

Jdforrester-WMF set Security to None.