Page MenuHomePhabricator

VisualEditor: [Regression] Section edit links have reverted to the old style (source only, not expanded)
Closed, ResolvedPublic

Description

screenshot

As of today, the section edit links seem to have reverted to the old style ([edit]). They don't expand and they open the source editor, even though VE is enabled (the 'Edit' and 'Edit source' tabs are there at the top. See screenshot.

Observed on en.wp (by me and User:KTC) and fr.wp (by me). KTC used firefox and chrome, and I used firefox 21.


Version: unspecified
Severity: major

Attached:

VisualEditor_-_No_section_edit_link.png (594×548 px, 76 KB)

Details

Reference
bz50731

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 1:43 AM
bzimport set Reference to bz50731.

I'd call this NOTABUG, since James has declared that visual section-editing won't be funded for the foreseeable future. So we now don't have an interface that claims functionality there aren't even plans to implement.

Well, if that's the case (I haven't heard about it, but I believe you) presumably the link should be renamed to "edit source" to be consistent with the naming of the tabs. Otherwise, I expect quite a bit of confusion.

Bug 48429#c35 - basically, visual section editing is a seriously hard problem, and isn't on the agenda any time soon.

Bizarrely, the mouseover "edit source" links appear briefly when mousing over "edit" links while VE is loading a page into edit mode.

Change 72069 had a related patch set uploaded by Krinkle:
mw.ViewPageTarget.init: Move edit section to top init.

https://gerrit.wikimedia.org/r/72069

Please consider fixing bug 50540 and maybe bug 50405, too.

They are directly dependent of this change. Fixing them now once and for all will prevent further hassle with changing editsection links back-and-forth.

Actually fixing bug 50540 would probably simplify code a lot and could therefore resolve bug 50405 as a side effect.

Change 72069 merged by jenkins-bot:
mw.ViewPageTarget.init: Move edit section to top init

https://gerrit.wikimedia.org/r/72069

Merged and will hopefully go out soon.