Page MenuHomePhabricator
Create Task
Maniphest T52793

Make ULS accessible from keyboard
Closed, ResolvedPublic
Actions

Assigned To
Nikerabbit
Authored By
• santhosh
Jul 5 2013, 10:49 AM
Tags
Referenced Files
F13781606: Screen Shot 2018-02-15 at 3.41.28 PM.png
Feb 15 2018, 11:58 PM
F13781592: Screen Shot 2018-02-15 at 3.51.26 PM.png
Feb 15 2018, 11:58 PM
F13781588: Screen Shot 2018-02-15 at 3.50.45 PM.png
Feb 15 2018, 11:58 PM
F13781616: Screen Shot 2018-02-15 at 3.42.52 PM.png
Feb 15 2018, 11:58 PM
F13100375: image.png
Feb 6 2018, 7:49 AM
F13100505: image.png
Feb 6 2018, 7:49 AM
F13100602: image.png
Feb 6 2018, 7:49 AM
F13100389: image.png
Feb 6 2018, 7:49 AM
View All 10 Files
Subscribers
Aklapper
Amire80
Arrbee
Etonkovidova
gerritbot
MattFitzpatrick
Nemo_bis
View All 11 Subscribers

Description

To make the ULS usable from the keyboard we need to:

  • Allow the ULS to be opened when pressing enter or space if the cog is focused.
  • Allow Display and Input tabs be focused in ULS personal toolbar mode using tab key and allow enter&space as trigger.
  • Allow Display and Input panes to be focused in ULS settings view using tab key and allow enter&space as trigger.

Pressing space should not scroll the screen when focus is on the cog or input/display.

See Also: T52575: Languages cogwheel missing accessibility features

Details

Reference
bz50793
SubjectRepoBranchLines +/-
Make ULS trigger and settings more keyboard accessiblemediawiki/extensions/UniversalLanguageSelectormaster+151 -176
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:47 AM
• bzimport added projects: UniversalLanguageSelector, Accessibility.
• bzimport set Reference to bz50793.
• bzimport added a subscriber: Unknown Object (MLST).
• santhosh created this task.Jul 5 2013, 10:49 AM
Nikerabbit added a comment.Jul 9 2013, 9:58 AM
  1. is done already.
MattFitzpatrick subscribed.Feb 13 2016, 6:26 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 13 2016, 6:26 AM
MattFitzpatrick added a subtask: T52921: Add more ARIA attributes to ULS cog.Feb 13 2016, 6:27 AM
MattFitzpatrick moved this task from Unsorted to Tabindex on the Accessibility board.Feb 13 2016, 6:30 AM
Amire80 mentioned this in T183175: Accessibilty testing for Compact Language Links.Dec 18 2017, 7:46 PM
Amire80 added a project: Language-2018-Jan-Mar.Jan 2 2018, 1:58 PM
Arrbee moved this task from Backlog to Priority backlog on the Language-2018-Jan-Mar board.Jan 18 2018, 8:59 AM
Nikerabbit claimed this task.Jan 31 2018, 11:27 AM
Nikerabbit moved this task from Priority backlog to In Progress on the Language-2018-Jan-Mar board.
gerritbot subscribed.Jan 31 2018, 2:55 PM

Change 407015 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/UniversalLanguageSelector@master] Make ULS settings more keyboard accessible

https://gerrit.wikimedia.org/r/407015

gerritbot added a project: Patch-For-Review.Jan 31 2018, 2:55 PM
Nikerabbit moved this task from In Progress to In Review on the Language-2018-Jan-Mar board.Jan 31 2018, 2:59 PM
Nikerabbit updated the task description. (Show Details)Jan 31 2018, 3:03 PM
Nikerabbit removed a subscriber: • wikibugs-l-list.
Volker_E subscribed.Feb 2 2018, 10:52 PM

@santhosh @Nikerabbit Would be helpful to have screenshots before/after patch.

• santhosh added a comment.EditedFeb 5 2018, 8:46 AM

Focus state of the language settings -> display settings:

image.png (289×715 px, 28 KB)

Focus state for the Language settings at Interlanguage position
image.png (183×300 px, 7 KB)

• Petar.petkovic mentioned this in T186551: Increase consistency among instances of the ULS.Feb 5 2018, 7:11 PM
Nikerabbit added a comment.Feb 6 2018, 7:49 AM

PS7:

image.png (439×735 px, 22 KB)

Wikipedia:
image.png (396×595 px, 11 KB)

Two, possibly related issues:
Ghost pointer appears in Firefox on hover (the white thing is the page content, not the popup):

image.png (174×228 px, 4 KB)

Ghost line appears in Chrome on hover:
image.png (168×223 px, 3 KB)

Nikerabbit moved this task from In Review to In Progress on the Language-2018-Jan-Mar board.Feb 6 2018, 8:33 AM
Nikerabbit moved this task from In Progress to Blocked on the Language-2018-Jan-Mar board.Feb 6 2018, 2:08 PM
Arrbee moved this task from Blocked to In Review on the Language-2018-Jan-Mar board.Feb 8 2018, 8:01 AM
Nikerabbit moved this task from In Review to QA on the Language-2018-Jan-Mar board.Feb 12 2018, 5:01 PM
Nikerabbit removed a project: Patch-For-Review.
gerritbot added a comment.Feb 12 2018, 5:19 PM

Change 407015 merged by jenkins-bot:
[mediawiki/extensions/UniversalLanguageSelector@master] Make ULS trigger and settings more keyboard accessible

https://gerrit.wikimedia.org/r/407015

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)).Feb 12 2018, 6:00 PM
Etonkovidova closed this task as Resolved.Feb 15 2018, 11:58 PM
Etonkovidova subscribed.

Checked in wmf.21 - ULS seems to be accessible according to the specs in the ticket:

Screen Shot 2018-02-15 at 3.50.45 PM.png (187×281 px, 18 KB)

Screen Shot 2018-02-15 at 3.51.26 PM.png (292×883 px, 64 KB)

@Amire80, @Pginer-WMF - should be selection of languages be accessible also? If I select via keyboard 'Language settings'->'Display' and then click three dots menu - I am not able to select language:

Screen Shot 2018-02-15 at 3.41.28 PM.png (331×915 px, 45 KB)

Even after typing a specific language that is presented in the list, I have no way to enter it via keyboard.
Screen Shot 2018-02-15 at 3.42.52 PM.png (367×896 px, 42 KB)

Should be a separate ticket or it's ok for now?

KartikMistry moved this task from QA to Done on the Language-2018-Jan-Mar board.Feb 16 2018, 7:02 AM
Nikerabbit added a comment.Feb 16 2018, 7:26 AM
In T52793#3977473, @Etonkovidova wrote:

Even after typing a specific language that is presented in the list, I have no way to enter it via keyboard.

Screen Shot 2018-02-15 at 3.42.52 PM.png (367×896 px, 42 KB)

Pressing enter selects the language for me. It's true that tabbing into the list of languages is not currently possible (except in CLL list)

Etonkovidova mentioned this in T187964: Enable up/down keys for navigating the ULS menu.Feb 22 2018, 12:09 AM

I filed T187964: Enable up/down keys for navigating the ULS menu as a separate issue.

Etonkovidova added a subtask: T187964: Enable up/down keys for navigating the ULS menu.Feb 22 2018, 12:12 AM
Pginer-WMF closed subtask T187964: Enable up/down keys for navigating the ULS menu as Resolved.Jan 27 2023, 8:53 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL