Page MenuHomePhabricator

Clarify the usage of trigger html element classes and ids
Open, LowPublic

Description

Right now we have .uls-trigger and .uls-settings-trigger and we need various checks everywhere to see which one is in use.

I propose:

  • All triggers have .uls-trigger
  • Primary trigger of the page also has #uls-primary-trigger
  • Depending on the position of the primary trigger they also have #uls-position-personal or #uls-position-interlanguage

Version: master
Severity: normal

Details

Reference
bz50856

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:51 AM
bzimport set Reference to bz50856.
bzimport added a subscriber: Unknown Object (MLST).

This seems to be a refactoring request. Can we discuss in the team how we should deal with these? I don't think bugzilla is the right thing for this. If there is technical debt, it should probably be task cards in mingle.

I'm making this a normal bug, as it is a blocker for simplifying browser tests.