Page MenuHomePhabricator

VisualEditor: Pre-fill the section title in the edit summary when launched from a section edit link
Closed, ResolvedPublic

Description

Even though section editing in VE is a long way off, it would be really helpful if the title of the section you click edit on was automatically included in the edit summary in the same way that the source editor does. For example, when making [https://en.wikipedia.org/w/index.php?title=Viareggio_train_derailment&diff=next&oldid=563164136 this edit] I launched the VE by clicking on the edit link for the "See also" section, so I was expecting the edit summary to begin with the usual "-> See also". This provides context for the edit summary and so helps give context at recent changes and on watchlists.


Version: unspecified
Severity: enhancement
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=56891
https://bugzilla.wikimedia.org/show_bug.cgi?id=51903

Details

Reference
bz50872

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:52 AM
bzimport set Reference to bz50872.

(In reply to comment #0)

Even though section editing in VE is a long way off, it would be really
helpful if the title of the section you click edit on was automatically
included in the edit summary in the same way that the source editor does.
For example, when making https://en.wikipedia.org/w/?diff=next&oldid=563164136
this edit I launched the VE by clicking on the edit link for the "See also"
section, so I was expecting the edit summary to begin with the usual "-> See
also". This provides context for the edit summary and so helps give context
at recent changes and on watchlists.

Won't this be rather mis-leading? Normally reviewers will expect the changes to be limited to that section, whereas editors are unlikely to keep their changes restricted in that way. Potentially we could add it into the edit summary box before the user adds anything, so they can remove it if they want?

  • Bug 50535 has been marked as a duplicate of this bug. ***

Absolutely it can (and probably should) be removable.

As for editing other sections, hmm. My initial thought is to wonder whether it could be detectable from the diff generator which section(s) have been edited?

Well, having a misleading "edit section" link isn't considered a problem.

  • Bug 51343 has been marked as a duplicate of this bug. ***

Change 74545 had a related patch set uploaded by Esanders:
Prepend section title to edit summary

https://gerrit.wikimedia.org/r/74545

  • Bug 51903 has been marked as a duplicate of this bug. ***

(In reply to comment #7)

  • Bug 51903 has been marked as a duplicate of this bug. ***

not exactly: this bug is about "when launched from section edit link".

IMO, this will be wrong: VE does not support section edit, and a user can launch VE from a section edit link, and then do whatever anywhere on the page.

bug 51903 asked VE to analyze the page when the user press "save", find out whether or not the changes are confined to a specific section, and if so (regardless of how VE was launched), add the section name to the summary.

so i do not think these two are truly "duplicates".
if anything, this bug should be marked "invalid" and bug 51903 should be resurrected (51903 was opened as "enhancement request").

peace.

Change 74545 merged by jenkins-bot:
Prepend section title to edit summary

https://gerrit.wikimedia.org/r/74545

Done and will be deployed tomorrow.