Page MenuHomePhabricator

Various links to special pages are not constructed correctly
Closed, ResolvedPublic

Description

I noticed various calls like

$specialPage->getTitle()->getLocalURL() . '/' . $subpage

in Wikibase codebase which should be written as

$specialPage->getTitle( $subpage )->getLocalURL()


Version: unspecified
Severity: minor

Details

Reference
bz50890

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:54 AM
bzimport set Reference to bz50890.
bzimport added a subscriber: Unknown Object (MLST).

Change 114741 had a related patch set uploaded by Tobias Gritschacher:
Correct usage of getLocalURL

https://gerrit.wikimedia.org/r/114741

Change 114741 merged by jenkins-bot:
Correct usage of getLocalURL

https://gerrit.wikimedia.org/r/114741

Change 114751 had a related patch set uploaded by Tobias Gritschacher:
Correctly construct edit-links to SpecialPages in EntityView

https://gerrit.wikimedia.org/r/114751

Change 114751 merged by jenkins-bot:
Correctly construct edit-links to SpecialPages in EntityView

https://gerrit.wikimedia.org/r/114751