Page MenuHomePhabricator

VisualEditor: Transclusion icon appears on the opposite side of the page in RTL wikis
Closed, ResolvedPublic

Description

Replication steps:

  1. go here: https://he.wikipedia.org/wiki/%D7%A8%D7%97%D7%95%D7%91_%D7%99%D7%A8%D7%95%D7%A9%D7%9C%D7%99%D7%9D?veaction=edit
  1. Click the box on the left (a 'street' template in the hebrew wiki)
  1. The "Transclusion" icon appears on the right edge instead of the left.

Happens in Chrome and Firefox 22.0 under Windows.

I suspect this is again a problem with the flipped position settings. I will take a look in the code.


Version: unspecified
Severity: normal

Details

Reference
bz50905

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:55 AM
bzimport set Reference to bz50905.

confirmed on Arch linux with FF 22.

This may be an issue with the way the icon appears in general, not just specifically RTL. It seems the transclusion icon pops up on the side of the page, assuming the position is always on the side -- instead of, perhaps, appearing where the template box is located regardless of alignment.

I am not sure if this fix shouldn't be a deeper VE fix rather than the language-directionality specific fix.

(In reply to comment #2)

This may be an issue with the way the icon appears in general, not just
specifically RTL. It seems the transclusion icon pops up on the side of the
page, assuming the position is always on the side -- instead of, perhaps,
appearing where the template box is located regardless of alignment.

I am not sure if this fix shouldn't be a deeper VE fix rather than the
language-directionality specific fix.

Yes, I think a deeper fix might be appropriate - would you want to do that, or should I ask Rob?

Change 79165 had a related patch set uploaded by Mooeypoo:
Fixing inspector popup position

https://gerrit.wikimedia.org/r/79165

I posted a fix which seems to work but requires some testing and review. Also testing in RTL seems to work.

  • Bug 53161 has been marked as a duplicate of this bug. ***

Change 79165 merged by jenkins-bot:
Fixing inspector popup position

https://gerrit.wikimedia.org/r/79165