Page MenuHomePhabricator

VisualEditor: Clearer message when cancelling out of active edit
Closed, ResolvedPublic

Description

An English Wikipedia user requests clarification of the "cancel" process, saying:

"If you open a page in the VisualEditor, make a few changes, and then decide to hit the "Cancel" button, you get a message that says "Are you sure you want to go back to view mode without saving first?". The options are "OK" and "Cancel", which aren't really proper answers to this yes/no question. As such, I'd like to request that instead the buttons be replaced with "Yes" and "No", which are clear responses to the question. -Thunderforge (talk) 21:36, 6 July 2013 (UTC)"


Version: unspecified
Severity: enhancement

Details

Reference
bz50955

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:58 AM
bzimport set Reference to bz50955.

Unfortunately we can't actually replace the "OK" and "Cancel" buttons' text - that's supplied by the browser as is unchangeable.

What we can do is tweak the message so it's clear what this does, perhaps. Any ideas what might work better?

ignatzmice.wiki wrote:

See bug 51655, which should probably be closed as a duplicate. (On enwiki I'd say "merge".)

  • Bug 51655 has been marked as a duplicate of this bug. ***

From bug 51655 comment 1:

The confirmation dialog should have more descriptive buttons, such as
[Discard edits] [Continue editing]
, or
[Leave editing mode] [Return to editing]
, etc.
For this to happen, it needs to become a jQuery dialog.
In fact, VE shouldn't use native confirm() dialogs; the implementation in
most browsers is crappy.

Change 130394 had a related patch set uploaded by Alex Monk:
Swap from using native confirm() to using an OOUI dialog when cancelling

https://gerrit.wikimedia.org/r/130394

Change 132113 had a related patch set uploaded by Alex Monk:
Add confirmation dialog

https://gerrit.wikimedia.org/r/132113

Change 132316 had a related patch set uploaded by Alex Monk:
Add confirmation dialog messages to MW core

https://gerrit.wikimedia.org/r/132316

Change 132318 had a related patch set uploaded by Alex Monk:
Register OOUI confirmation dialog with windowFactory

https://gerrit.wikimedia.org/r/132318

Change 132113 merged by jenkins-bot:
Add confirmation dialog

https://gerrit.wikimedia.org/r/132113

Change 132318 merged by jenkins-bot:
Update OOjs UI to v0.1.0-pre (80f1797a5c)

https://gerrit.wikimedia.org/r/132318

Change 132316 merged by jenkins-bot:
Update OOjs UI to v0.1.0-pre (80f1797a5c)

https://gerrit.wikimedia.org/r/132316

Change 130394 merged by jenkins-bot:
Swap from using native confirm() to using an OOUI dialog when cancelling

https://gerrit.wikimedia.org/r/130394