Page MenuHomePhabricator

VisualEditor: Reduce padding in editnotice popup because some existing edit notices already have some margin
Open, LowPublicFeature

Description

An editor from pt.wikipedia writes:

[E]ditnotices seems strange inside the flyout because there's a weird padding inside the popup, without the padding the templates would look nicer (there´s already padding in most edinotices templates by default). Dianakc (talk) 23:56, 6 July 2013 (UTC)


Version: unspecified
Severity: enhancement

Details

Reference
bz50956

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:58 AM
bzimport set Reference to bz50956.

(In reply to comment #0)

An editor from pt.wikipedia writes:

[E]ditnotices seems strange inside the flyout because there's a weird padding
inside the popup, without the padding the templates would look nicer (there´s
already padding in most edinotices templates by default). Dianakc (talk)
23:56,
6 July 2013 (UTC)

I'm not sure that it's a better solution to get editors to make edit notices in uneditable HTML boxes, rather than the padding be system-level. The padding is designed to take normal edit notices; if you make fancy ones that break, the onus is generally on you. :-)

Note that we're planning on having setting/editing/removing page-level edit notices built into VisualEditor in the next few months, which will make enwiki's solution available to all wikis.

Hi James,

I don't know what mean you by normal edit notices :) A simple 100% div, with background color but without padding would look weird inside the flyout.
We are rethinking the editnotices design/content and right now they look somewhat awkward within this asymmetrical padding. If someone ever need a margin it can be done within the editnotices itself, but this mandatory padding limits the design a lot.

(In reply to comment #2)

Hi James,

I don't know what mean you by normal edit notices :) A simple 100% div, with
background color but without padding would look weird inside the flyout.
We are rethinking the editnotices design/content and right now they look
somewhat awkward within this asymmetrical padding. If someone ever need a
margin it can be done within the editnotices itself, but this mandatory
padding
limits the design a lot.

Normal edit notices are text only (or bold/italics/links). Adding any further styling, including <span>s, <div>s, images, etc. is likely to break in a variety of situations and isn't really intended behaviour for the tool.

Aklapper changed the subtype of this task from "Task" to "Feature Request".Feb 4 2022, 11:13 AM
Aklapper removed a subscriber: TrevorParscal.