Page MenuHomePhabricator

Increase wgQueryCacheLimit from 1000 to 2000 on en.wiki
Closed, ResolvedPublic

Description

Per T52832 (and the comments in InitialiseSettings.php), I would like to propose raising wgQueryCacheLimit from 1000 to 2000 on en.wiki. Currently, it is set to 1000 for en.wiki, 2000 for de.wiki, and 5000 for all other wikis.

See Also: T46321

Details

Reference
bz50979

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:00 AM
bzimport set Reference to bz50979.
bzimport added a subscriber: Unknown Object (MLST).

Guess Asher/Tim should probably weigh in on this

*poke* Adding springle as well.

All those queries are generally filesorts and quite expensive. I would be very surprised if the query cache limit had much of an affect on anything performance wise.

@Bawolff: Does that mean you would be OK with increasing it to 2000 or are you suggestion some other course of action (like getting rid of the limits)?

I mean im ok with increasing. Some limit is probably needed, i just doubt 1000 vs 2000 would make any appreciable difference. I would go as far as to suggest 5000 to be reasonable.

Since cached special pages are paged via offset, a super really high limit would eventually introduce performance problems on the viewing cached results stage. But that's wiki agnostic anyways. No limits would probably also result in inserting a hundred thousand rows which would also be bad.

(i should be 100% clear that this is just my personal opinion. I definitely *do not* have the authority to decree what is and is not acceptable performance wise for wikimedia. I also have not profiled different settings or otherwise tested)

matmarex set Security to None.
matmarex removed a subscriber: Unknown Object (MLST).

Are there any further comments on this, or is it ok to patch yet?

Mdann52 claimed this task.

Appears to have been done (default is 5000, can't see any other limits)