Page MenuHomePhabricator

browsertests role permanently changes system default ruby to 1.9
Closed, ResolvedPublic

Description

17:33 <ori-l> I wonder if that's because it was an existing VM on which he has previously used the browsertest role
17:33 <ori-l> which (among other things) sets ruby 1.9 as the system default ruby
17:33 <superm401> ori-l, probably
17:33 <superm401> You're not using rvm?
17:34 <ori-l> no. it might be a good idea to set the system ruby to 1.9 by default, for the sake of consistency and predictability
17:34 <ori-l> that's a weird and surprising side-effect for a role to have
17:34 <superm401> ori-l, definitely.
17:34 <superm401> If everything supports Ruby 1.9, might as well go for it.
17:35 <ori-l> well, but IIRC nothing other than browsertests depends on ruby 1.9, and it requires downloading a bunch of packages
17:35 <ori-l> so i was hoping to spare users that don't want/need browsertests the cost of the download
17:36 <ori-l> it's a bug either way; if we keep it specific to browsertests, the ruby setting should be specific to browsertests; if general, then general. i'll file a bug.


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=61285

Details

Reference
bz50993

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:01 AM
bzimport set Reference to bz50993.

[mass-moving from Tools>MediaWiki-Vagrant to separate product. See bug 54041. Filter bugmail on this comment.]

Change 137483 had a related patch set uploaded by Dduvall:
Ruby module for better management of ruby and gems

https://gerrit.wikimedia.org/r/137483

Change 137483 merged by jenkins-bot:
Ruby module for better management of ruby and gems

https://gerrit.wikimedia.org/r/137483