"pages" property does not allow for integers and arrays of integers
Closed, DeclinedPublic
Actions

Assigned To

None

Authored By

	• bzimport
	Jul 9 2013, 7:20 PM

Description

Author: molly.white5

Description:
The code that I took from EventLogging only allows arrays to contain one type of value. The "pages" property should allow for something like the following:

[2, [5,8]]

This would indicate that the section included pages 2, 5, 6, 7, 8.

Right now the validation either allows only numbers, which would require the JSON to be formatted:

[2, 5, 6, 7, 8]

or only arrays, which would require the JSON to be formatted:

[[2], [5,8]]

Both of these seem a little silly, so it seems like it would be worth adjusting the code to allow for more than one type of value, and, ideally, pushing the changes back to EventLogging as well.

Version: unspecified
Severity: normal

Details

Reference: bz51063

Related Objects
Search...

Status	Subtype	Assigned	Task
Open	Feature	None	T66475 Make crosswiki bits and pieces truly global (tracking)
Open	Feature	None	T17073 Create a way for handling meta-organization of books
Open		None	T179790 Offer PDF export of entire wikisource proofread books
Open	Feature	None	T28448 Make Collection extension to automatically create collections for existing books on Wikibooks/Wikisources
Open		None	T14908 Option to protect all subpages and talk pages when protecting the page
Open	Feature	None	T17072 Protect, watchlist or delete a whole book at once
Open	Feature	None	T33254 Provide "Random page of this book" feature for use on Wikibooks projects
Open	Feature	None	T12092 Separate reference page for glossaries, bibliographies, etc
Resolved		None	T17070 Allow <ref>s from multiple pages to be collected into one <references/> on another page
Open	Feature	None	T17075 Per book, category and/or template CSS and JavaScript
Open	Feature	None	T17074 List, count and search all books
Open	Feature	None	T17071 Wikibooks/Wikisource needs means to associate separate pages with books
Declined		None	T52386 Create basic tool for reading books (group of pages)
Resolved		None	T52957 Populate metadata, chapterlist, and prev/next in navbar from the JSON structure.
Declined		None	T52958 Validate a book's JSON block against a JSON schema.
Declined		None	T53063 "pages" property does not allow for integers and arrays of integers

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:05 AM

• bzimport added a project: MediaWiki-extensions-BookManagerv2.

• bzimport set Reference to bz51063.

• bzimport created this task.Jul 9 2013, 7:20 PM

I'm not able to reproduce this; can you provide some additional details?

Here's what I tried:

$schema = array( 'properties' => array(
    'collection' => array(
        'type' => 'array',
    ),
) );

$obj = array( 'collection' => array( 8, "hello", array(6) ) );
var_dump ( efSchemaValidate( $obj, $schema ) ); // output:

bool(true)

molly.white5 wrote:

Sure. The schema that I am using is https://meta.wikimedia.org/wiki/Schema:BookManagerv2. The relevant bits are lines 179–199. Is this the incorrect way to indicate that an array should contain numbers or arrays of numbers?

In your example, why is the string passing the validation?

molly.white5 wrote:

The "Refactoring of Proofread Page extension" is working on a system to populate book pages with the <pages index> tags, and so we are stepping back from that feature. The "pages" property will be removed from the schema entirely.

"pages" property does not allow for integers and arrays of integersClosed, DeclinedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

"pages" property does not allow for integers and arrays of integers
Closed, DeclinedPublic
Actions

Related Objects
Search...