Page MenuHomePhabricator
Create Task
Maniphest T53092

Images: Auto-external links to image files display the image inline
Closed, ResolvedPublic
Actions

Description

This is one of the more amazing bugs I can recall seeing.

If a page has a plain external link to an image file with no markup, e.g.

http://www.impactwrestling.com/images/stories/galleries/718-title.jpg

Then opening the Visual Editor on that page results in the external link being replaced with an actual fully rendered copy of the image. I haven't the wildest clue why an external link to an image would be translated into HTML markup that displays that image, but that seems to be what is happening.

I tried a few more dangerous file types (e.g. js, css, pdf) and those do not appear to be rendered / included, so apparently it is something specific about external links to image file types.

Version: unspecified
Severity: normal
URL: http://parsoid.wmflabs.org/en/User:Thryduulf/sandbox2?oldid=563640804

Details

Reference
bz51092

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:07 AM
• bzimport added a project: Parsoid.
• bzimport set Reference to bz51092.
Dragons_flight created this task.Jul 10 2013, 3:43 AM
Thryduulf added a comment.Jul 10 2013, 9:17 AM

Confirmed in Firefox 22 for JPG, PNG and SVG files but not for GIF or TIF files

https://en.wikipedia.org/w/index.php?title=User:Thryduulf/sandbox2&oldid=563640804

Thryduulf added a comment.Jul 10 2013, 10:00 AM

See also bug 51103 which is likely related to this one.

Jdforrester-WMF added a comment.Jul 10 2013, 5:09 PM

Turns into the following in Parsoid:

<img rel="mw:externalImage" alt="<filename>" src="<URL>">

Not good.

cscott added a comment.Jul 10 2013, 5:15 PM

ok, i'll take this one.

Jdforrester-WMF added a comment.Jul 10 2013, 6:17 PM

Having spoken to Roan, he says this is caused because he presumes that Parsoid assumes that $wgAllowExternalImages is true - it generally isn't, and certainly isn't in production for Wikimedia. :-)

Jdforrester-WMF added a comment.Jul 10 2013, 6:20 PM
  • Bug 51103 has been marked as a duplicate of this bug. ***
cscott added a comment.Jul 10 2013, 9:36 PM

Hm, but parserTests seem to run with $wgAllowExternalImages=true -- for example:

!! test
External image
!! input
External image: http://meta.wikimedia.org/upload/f/f1/Ncwikicol.png
!! result
<p>External image: <img src="http://meta.wikimedia.org/upload/f/f1/Ncwikicol.png" alt="Ncwikicol.png" />
</p>
!! end

gerritbot added a comment.Jul 10 2013, 10:14 PM

Change 73111 had a related patch set uploaded by Cscott:
Add wgAllowExternalImages option to parser tests.

https://gerrit.wikimedia.org/r/73111

cscott added a comment.Jul 11 2013, 4:41 PM

So I need to export the value of $wgAllowExternalImages in the mediawiki siteinfo in order to parse this correctly.

Alternatively, we could leave parsoid as-is and handle this in VE?

Jdforrester-WMF added a comment.Jul 11 2013, 5:03 PM

(In reply to comment #9)

So I need to export the value of $wgAllowExternalImages in the mediawiki
siteinfo in order to parse this correctly.

Alternatively, we could leave parsoid as-is and handle this in VE?

I don't think that would be appropriate; VE should not need to know about server configuration items like this, and it'd be an ugly hack to special-case certain kinds of images.

gerritbot added a comment.Jul 11 2013, 5:59 PM

Change 73199 had a related patch set uploaded by Cscott:
Export information about external image settings via siteinfo API.

https://gerrit.wikimedia.org/r/73199

gerritbot added a comment.Jul 16 2013, 2:10 PM

Change 73199 merged by jenkins-bot:
Export information about external image settings via siteinfo API.

https://gerrit.wikimedia.org/r/73199

gerritbot added a comment.Jul 16 2013, 6:02 PM

Change 73111 merged by jenkins-bot:
Add wgAllowExternalImages option to parser tests.

https://gerrit.wikimedia.org/r/73111

gerritbot added a comment.Jul 16 2013, 8:37 PM

Change 74053 had a related patch set uploaded by Cscott:
Handle $wgAllowExternalImages in wiki configuration.

https://gerrit.wikimedia.org/r/74053

gerritbot added a comment.Jul 17 2013, 6:41 PM

Change 74053 merged by jenkins-bot:
Handle $wgAllowExternalImages in wiki configuration.

https://gerrit.wikimedia.org/r/74053

cscott added a comment.Jul 31 2013, 9:20 PM

Deployed and tested on https://en.wikipedia.org/wiki/User:Cscott/bug51092 --- all fixed!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL