Page MenuHomePhabricator

Click in Search field makes page go white
Closed, ResolvedPublic

Description

Seen in beta labs http://en.m.wikipedia.beta.wmflabs.org as of July 10 2013

click in Search field

page goes white

In production the page goes white not upon clicking in the Search area but only upon beginning to type text in the Search area.

This change caused a browser test to fail.


Version: unspecified
Severity: normal

Details

Reference
bz51204

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:46 AM
bzimport set Reference to bz51204.
bzimport added a subscriber: Unknown Object (MLST).

Created attachment 12834
difference between beta as of July 10 and production when clicking in Search

Just to be clear

Attached:

beta_vs_prod_behavior.png (292×658 px, 60 KB)

The design team prefers this new search UX (quote: "puts you in the zone"), though we'll need to add some additional styling to the blank search overlay so it doesn't look broken. If it's failing browser tests, I'm sure it's also confusing to human users :)

In the course of making the automated test for Search pass, I discovered that there are actually two search input elements on the page that seem to identify the same text field, but the first is never actually used to search. The user just clicks the first one in order to instantiate the second on the page. The first search input looks like

<form class="search-box" action="/w/index.php">
<input id="searchInput" class="search" type="search" autocomplete="off" accesskey="f" title="Search Wikipedia [f]" placeholder="Search Wikipedia" name="search">>

and the second one looks like

<form class="search-box" action="/w/index.php" method="get">
<input class="search" type="search" name="search">
<a class="clear"></a>

Note the lack of an :id value for the second.

Correct this is due to the way overlays currently work in mobile. This should be easy to fix once story 920 is completed which involves a slight rewrite of how overlays work...

https://mingle.corp.wikimedia.org/projects/mobile/cards/920

Fixed in a nice way now, so either focus or typing dtrt