Page MenuHomePhabricator

VisualEditor: Beta notices fly-out too narrow on some systems (even though its width is specified in ems)
Closed, ResolvedPublic

Description

The Beta notice looks strange to me:
http://i.imgur.com/H5n3XdD.png
ff23 linux


Version: unspecified
Severity: minor
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=52176

Details

Reference
bz51335

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:55 AM
bzimport set Reference to bz51335.

Which page / URL does this happen on? And what exactly is "strange"? The line break between "Leave" and "feedback", or anything else? Feel free to edit the bug summary to be more specific. Thanks!

Screenshot

Adding a screenshot of how it looks for me (Firefox22, Windows 7).

Attached:

beta.png (156×186 px, 4 KB)

(In reply to comment #1)

Which page / URL does this happen on? And what exactly is "strange"? The line
break between "Leave" and "feedback", or anything else? Feel free to edit the
bug summary to be more specific. Thanks!

I suspect it is the font (DejaVu?) that is common on Linux systems. It has wider characters than Arial (used on Windows).

The Beta popup should be made a little bit wider to accommodate this font.

(In reply to comment #3)

(In reply to comment #1)

Which page / URL does this happen on? And what exactly is "strange"? The line
break between "Leave" and "feedback", or anything else? Feel free to edit the
bug summary to be more specific. Thanks!

I suspect it is the font (DejaVu?) that is common on Linux systems. It has
wider characters than Arial (used on Windows).

The Beta popup should be made a little bit wider to accommodate this font.

The width is defined in terms of the font used (ems). I'm not sure how this fails due to that font - unless its em width is wrong somehow?

Note that we've just changed the language in the beta notices and expanded the width to compensate (deployment will be tomorrow afternoon PDT). Interested to know if this has an impact on this issue.

  • Bug 51618 has been marked as a duplicate of this bug. ***

This flyout is now much wider.