Page MenuHomePhabricator

Title jumps on open
Closed, InvalidPublic

Description

Go to http://en.m.wikipedia.org/wiki/Douglas_Engelbart (logged out view)
Set the device width to 320px

Expand "Early life and education"
The heading jumps down to a second row.

Expected:
It shouldn't jump down


Version: unspecified
Severity: normal

Details

Reference
bz51550

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 22 2014, 2:10 AM
bzimport set Reference to bz51550.
bzimport added a subscriber: Unknown Object (MLST).

Change 74395 had a related patch set uploaded by Jdlrobson:
Bug 51550: Always set padding right

https://gerrit.wikimedia.org/r/74395

Created attachment 12885
Before

Attached:

Screen_Shot_2013-07-18_at_12.10.48_PM.png (361×313 px, 39 KB)

Created attachment 12886
After

Attached:

Screen_Shot_2013-07-18_at_12.10.43_PM.png (297×302 px, 24 KB)

Brought Brandon into this discussion - as Juliusz pointed out there are two ways of looking at this

  • The edit icon is not shown when the section is toggled thus there is available whitespace and not taking up that available whitespace is weird
  • The last word of the title jumping is jarring - your attention is immediately drawn to the word below the section. This is also weird.

We can not stop the jumping for anon users but it does feel like it would be better to show some visual indicator that an edit icon will appear there.

Is there a good reason we don't always show the edit icon to logged in users (just possibly gray it out until the content is visible?)

Created attachment 12890
Would hiding the text under the edit button be a terrible thing...?

Attached:

Screen_Shot_2013-07-18_at_6.43.09_PM.png (365×310 px, 41 KB)

Change 74395 abandoned by Jdlrobson:
Bug 51550: Always set padding right

Reason:
Abandoning this for time being until we have some consensus.. (although bear in mind I still think current behaviour is very wrong and bugs me :-)!)

https://gerrit.wikimedia.org/r/74395

Any suggestions of what to do on this if anything? Maryana?

No longer a valid bug CTA is now always shown.