Page MenuHomePhabricator

Vector: Module "ext.vector.footerCleanup" and "ext.vector.collapsibleNav" should not each load in a separate http request
Closed, ResolvedPublic

Description

In production right now we're causing RL to have to do a separate HTTP request for modules like "ext.vector.footerCleanup".

This is pointless, it should be part of the regular queue that is on every page. It was perhaps useful in the past when there were more modules in the "ext.vector" group that load on every page from the same queue (so that different pages with different modules in their queue would share this cache), but right now this is the only one left and no longer justified being in a separate request.


Version: unspecified
Severity: major
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=45051

Details

Reference
bz51564

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:11 AM
bzimport set Reference to bz51564.

Since ext.vector.footerCleanup and ext.vector.collapsibleNav are in the top and bottom queue respectively they also don't load together but are two separate requests.

Well, the best way to fix this would be to just fix bug 45051.

(In reply to comment #2)

Well, the best way to fix this would be to just fix bug 45051.

Agreed.

Change 74315 had a related patch set uploaded by Krinkle:
Remove cache group "ext.vector" from modules definitions

https://gerrit.wikimedia.org/r/74315

True, but that might take a while.

Saving 2 http requests globally is a big fish to catch for such a small bait.

Change 74315 merged by jenkins-bot:
Remove cache group "ext.vector" from modules definitions

https://gerrit.wikimedia.org/r/74315