Investigate whether MW_NO_OUTPUT_BUFFER can be removed from WebStart.php
Open, LowPublic
Actions

Assigned To

None

Authored By

	• MZMcBride
	Jul 17 2013, 9:38 PM

Description

As reported by e0je in MediaWiki-General earlier today, includes/WebStart.php currently contains the following line (cf. https://git.wikimedia.org/blob/mediawiki%2Fcore.git/cd951c7458abfd91c8564874d5ffe08dc7b1b817/includes%2FWebStart.php#L149):

if ( !defined( 'MW_NO_OUTPUT_BUFFER' ) && ob_get_level() == 0 ) {

Searching through the current codebase, there were no other references to "MW_NO_OUTPUT_BUFFER".

Researching the history found the following:

Tim introduced "MW_NO_OUTPUT_BUFFER" on 2007-02-19:

This change added "MW_NO_OUTPUT_BUFFER" to includes/WebStart.php and config/index.php.

Brion moved most of config/index.php's logic to config/Installer.php on 2009-08-19:

Chad H. deleted config/Installer.php on 2010-12-10:

As far as I can tell, MW_NO_OUTPUT_BUFFER is no longer defined in the codebase and the check in includes/WebStart.php is no longer needed. But perhaps I'm mistaken.

Version: 1.22.0
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=51582

Details

Reference: bz51576

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 1:43 AM

• bzimport added a project: MediaWiki-General.

• bzimport set Reference to bz51576.

• bzimport added a subscriber: Unknown Object (MLST).

• MZMcBride created this task.Jul 17 2013, 9:38 PM

Actually, the bug is that it's unused, not that it exists. I filed bug 51582 for this.

Aklapper removed a subscriber: • wikibugs-l-list.Apr 12 2020, 9:55 AM

Investigate whether MW_NO_OUTPUT_BUFFER can be removed from WebStart.phpOpen, LowPublicActions

Description

if ( !defined( 'MW_NO_OUTPUT_BUFFER' ) && ob_get_level() == 0 ) {

Details

Event Timeline

Investigate whether MW_NO_OUTPUT_BUFFER can be removed from WebStart.php
Open, LowPublic
Actions