Page MenuHomePhabricator

Liquid threads and mobile talk dislike each other
Closed, ResolvedPublic

Description

Go to https://m.mediawiki.org/wiki/Requests_for_comment/Scoping_site_CSS
Click talk.
Nothing shows despite there being underlying content but you can add topics..

I hate liquid threads but not sure what we should do here.


Version: unspecified
Severity: normal

Details

Reference
bz51586

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:43 AM
bzimport set Reference to bz51586.

Honestly, we should really propose killing LQT on mediawiki.org - it's going to be replaced by Flow in the (hopefully) not-too-long term anyway...

LQT can't go until someone comes up with a way to extract LQT conversations and either put them in a format Flow can understand or output as a normal talk page.

Currently the response for:
https://m.mediawiki.org/w/api.php?format=json&action=mobileview&page=Talk%3ARequests+for+comment%2FScoping+site+CSS&variant=en&redirect=yes&prop=sections%7Ctext&noheadings=yes&sectionprop=level%7Cline%7Canchor&sections=all

is:
{"warnings":{"main":{"*":"Unrecognized parameter: 'redirects'"}},"mobileview":{"sections":[{"id":0,"text":""}]}}

Could the api return something different when liquid threads is being used?

Poke.. anyway to find out when a page has LiquidThreads enabled?

LiquidThread invokes onAPIQueryAfterExecute and seems to add a parameter. Could we somehow incorporate this in the above api response?

https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FLiquidThreads/4f2fbead90ac9f8373d2766c6460919b8f4bffce/classes%2FHooks.php#L888

If we can, I suggest we just display a message saying "talk not currently available on this page".

My api seems to always say it is not LQT enabled so not sure if this patch worked correctly..

Change 84466 had a related patch set uploaded by Jdlrobson:
Redirect to talk page when liquid threads enabled

https://gerrit.wikimedia.org/r/84466

Change 84466 merged by jenkins-bot:
Redirect to talk page when liquid threads enabled

https://gerrit.wikimedia.org/r/84466