Page MenuHomePhabricator

VisualEditor: Make it clearer that the clear formatting button does something (clears pre-annotations) if any are set
Closed, ResolvedPublic

Description

In the visual editor, the button to remove formatting activates if the cursor is placed on a formatted (bold or italic) character. However clicking the button has no effect unless text is selected.

Either the button should be disabled when no text is selected, or clicking it when no text is selected should have an effect (probably remove formatting from the current word).


Version: unspecified
Severity: normal

Details

Reference
bz51756

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:55 AM
bzimport set Reference to bz51756.

Although the interface doesn't clearly indicate this, when the cursor is inside bold text, the toolbar shows "Bold" active. When you then click "Clear formatting", nothing inside the document will change (since no text is selected) however it does affect text entered from this point on.

Basically when your cursor is inside or against bold text, you'd expect text entered after it will also be bold. Clearing formatting at that point means it will unbold your cursor (if you know what I mean).

This was fixed by only showing it as enabled when there's a pre-annnotation stack.