Page MenuHomePhabricator

VisualEditor shows rowspan="4" on template generated tables
Closed, ResolvedPublic

Description

Screenshot of the table

See the link above and the attached screenshot.


Version: unspecified
Severity: normal
URL: https://pt.wikipedia.org/wiki/La_Liga_de_2006%E2%80%9307?oldid=36362539&veaction=edit

Attached:

Captura_de_tela_de_2013-07-22_09:17:12.png (388×1 px, 45 KB)

Details

Reference
bz51806

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:58 AM
bzimport added a project: Parsoid.
bzimport set Reference to bz51806.

Buggy template: http://pt.wikipedia.org/w/index.php?title=Predefini%C3%A7%C3%A3o:Tabfootrow&action=edit

It should be "|rowspan=..." instead of "||rowspan=..."

echo "{|\n|foo{{User:Ssastry/Templates/tabfootrow|rows=2|content=foobar}}\n|}" | node parse

works properly with the correct wikitext.

I am not editing the template -- someone on pt wikipedia (matmarex) should verify that existing pages wont break with the change and do it. But, offhand it does seem safe to fix.

I left a message in the talk page of one of the articles which uses the template:
https://pt.wikipedia.org/wiki/Discuss%C3%A3o:Primeira_Liga_de_2013%E2%80%9314
and in the thread where its author announced the new template:
https://pt.wikipedia.org/wiki/WP:EA#Novas_predefini.C3.A7.C3.B5es_para_tabelas_de_futebol

For now, I moved the relevant code from [[pt:Template:Tabfootrow]] to [[pt:Template:Tabfoot]] and then I updated the only two articles which uses that template and informed about this change in the talk page of one of them:
https://pt.wikipedia.org/wiki/Special:Contribs/Helder.wiki?dir=prev&offset=20130805170824&limit=11&uselang=en

Thanks for fixing the templates -- I will close this bug now without making any fixes in Parsoid. While we could fix Parsoid to accommodate bugs in wikitext and templates (and there are several scenarios that we handle), for one-off scenarios, it is better to fix the templates/wikitext rather than clutter the Parsoid code base with exceptional conditions. It is better in the long run and will enable maintenance of the code base.