Page MenuHomePhabricator

Changing HTML code for list output
Closed, ResolvedPublic

Description

Please change the old code in RelatedArticles.class.php

Html::closeElement( 'div' ) .
Html::closeElement( 'div' ) .
Html::openElement( 'div', array( 'id' => 'p-lang', 'class' => 'portal' ) ) .
Html::element( 'h3', array(), wfMessage( 'relatedarticles-title' )->text() ) .
Html::openElement( 'div', array( 'class' => 'body' ) ) .
Html::openElement( 'ul', array( 'class' => 'body' ) ) .
implode( '', $relatedArticles );

to

Html::closeElement( 'div' ) .
Html::closeElement( 'div' ) .
Html::openElement( 'div', array( 'id' => 'p-relatedarticles', 'class' => 'portal', 'role' => 'navigation' ) ) .
Html::element( 'h3', array(), wfMessage( 'relatedarticles-title' )->text() ) .
Html::openElement( 'div', array( 'class' => 'body' ) ) .
Html::openElement( 'ul' ) ) .
implode( '', $relatedArticles );

In line 3 id was changed from p-lang to p-relatedarticles because p-lang is already used. In the same line the role attribute was added.

In line 4 h3 must now noted instead of the former h5.

Next to the last line the class="body" attribute was removed. No longer necessary.


Version: master
Severity: major

Details

Reference
bz51870

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:02 AM
bzimport added a project: RelatedArticles.
bzimport set Reference to bz51870.
bzimport added a subscriber: Unknown Object (MLST).

Wrong id prevents Wikidata presenting "Languages" section

Change 75872 had a related patch set uploaded by Aude:
(bug 51870) fix html in toolbox for related articles

https://gerrit.wikimedia.org/r/75872

The next to the last line should be:

Html::openElement( 'ul', array() ) .

Change 75872 merged by Hoo man:
(bug 51870) fix html in toolbox for related articles

https://gerrit.wikimedia.org/r/75872

This looks good now. I'm closing it. Please reopen with link if it is still an issue somewhere. Thanks :)