Page MenuHomePhabricator

Changing HTML coding for list output in Insider.class.php
Closed, ResolvedPublic

Description

Please change the old code in Insider.class.php from

Html::closeElement( 'div' ) .
Html::closeElement( 'div' ) .
Html::openElement( 'div', array( 'id' => 'p-lang', 'class' => 'portal' ) ) .
Html::element( 'h3', array(), wfMessage( 'insider-title' )->text() ) .
Html::openElement( 'div', array( 'class' => 'body' ) ) .
Html::openElement( 'ul', array( 'class' => 'body' ) ) .
implode( '', $insiders );

to

Html::closeElement( 'div' ) .
Html::closeElement( 'div' ) .
Html::openElement( 'div', array( 'id' => 'p-insiders', 'class' => 'portal', 'role' => 'navigation' ) ) .
Html::element( 'h3', array(), wfMessage( 'insider-title' )->text() ) .
Html::openElement( 'div', array( 'class' => 'body' ) ) .
Html::openElement( 'ul' ) ) .
implode( '', $insiders );

In line 3 id was changed from p-lang to p-insiders because p-lang is already used. In the same line the role attribute was added.

In line 4 h3 must now noted instead of the former h5 (in current master correct).

Next to the last line the class="body" attribute was removed. No longer necessary.


Version: master
Severity: major

Details

Reference
bz51871

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:02 AM
bzimport set Reference to bz51871.
bzimport added a subscriber: Unknown Object (MLST).

Wrong id prevents Wikidata presenting "Languages" section

Change 75877 had a related patch set uploaded by Aude:
(bug 51871) fix html for toolbox section

https://gerrit.wikimedia.org/r/75877

The next to the last line should be:

Html::openElement( 'ul', array() ) .

Change 75877 merged by Hoo man:
(bug 51871) fix html for toolbox section

https://gerrit.wikimedia.org/r/75877

This is merged now. Closing. Please reopen if it is still an issue.