Jenkins should flag usage of deprecated features
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ori
	Jul 23 2013, 8:09 PM

Description

Jenkins should set $wgDevelopmentWarnings = true, and keep a count of E_USER_DEPRECATED errors in the PHP error log that are generated by the test suite. If a patch causes that number to go up, Jenkins should -1 it.

Version: wmf-deployment
Severity: enhancement

Details

Reference: bz51908

Related Objects
Search...

Status	Assigned	Task
Resolved	hashar	T53908 Jenkins should flag usage of deprecated features
Resolved	hashar	T50002 Jenkins: Assert no PHP errors (notices, warnings) were raised or exceptions were thrown
Resolved	matthiasmullie	T89691 Fix "InvalidDataException from NotificationListener.php: Invalid metadata for revision"
Resolved	Krinkle	T91567 Fix "DatabaseSqlite::replace/single-row NOT NULL constraint failed" for md_module table
Resolved	None	T91763 Fix "PHP Warning: No route to fetch banner choice data configured" in QUnit runs
Resolved	None	T92000 PHPUnit: make tests independent of global CN config variables
Resolved	• Mattflaschen-WMF	T93463 Database field 'workflow.workflow_wiki' too short (not compatible with mediawiki's iw_wikiid)
Resolved	• Springle	T93844 Run Flow's patch-increase_width_wiki_fields in WMF production
Resolved	matthiasmullie	T101388 Fix exception in unit test "FlowException: Formatting for wrong user" from RevisionFormatter
Resolved	matthiasmullie	T101702 Fix database error "Flow\Repository\TreeRepository::insert: Can't reopen table: 'unittest_flow_tree_node'"
Duplicate	None	T121083 Cannot find site jenkins_u3_mw
Resolved	Tgr	T153729 CI tests throw warning "Cannot find site mywiki in sites table"
Resolved	Krinkle	T126596 During update.php (and install), add an entry in the sites table / SiteStore for the local wiki

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:05 AM

• bzimport added a project: Continuous-Integration-Infrastructure.

• bzimport set Reference to bz51908.

• bzimport added a subscriber: Unknown Object (MLST).

ori created this task.Jul 23 2013, 8:09 PM

Adding $wgDevelopmentWarnings = true was bug bug 38882, it was no more applied until I refactor the way we inject MediaWiki settings in build ( https://gerrit.wikimedia.org/r/#/c/89837/ ).

Long story short, the setting is enabled since roughly Oct 15 2013.

I am not sure whether a E_USER_DEPRECATED warning would throw an exception though. Might want to write a test case and see what happens.

• demon unsubscribed.Dec 16 2014, 6:05 PM

Krinkle added a subtask: T50002: Jenkins: Assert no PHP errors (notices, warnings) were raised or exceptions were thrown.Jan 8 2015, 1:24 PM

Krinkle moved this task from Untriaged to Backlog on the Continuous-Integration-Infrastructure board.Apr 13 2015, 4:39 PM

Ricordisamoa subscribed.Jan 4 2016, 4:02 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 4 2016, 4:02 AM

Krinkle unsubscribed.Feb 23 2016, 4:52 PM

Krinkle mentioned this in T128779: In CI, local wiki ID is not found in the sites table.Mar 7 2016, 8:00 PM

thcipriani closed subtask T50002: Jenkins: Assert no PHP errors (notices, warnings) were raised or exceptions were thrown as Resolved.Aug 23 2017, 4:56 PM

Liuxinyu970226 subscribed.Aug 24 2017, 1:10 PM

Aklapper added a project: Technical-Debt.Sep 29 2017, 9:53 PM