Page MenuHomePhabricator

"Related sites" on it.wikivoyage still uses <h5> instead of <h3> (though bug 51625 got fixed)
Closed, DeclinedPublic

Description

The following two sidebar titles: Altri progetti (Related sites) e Pagine correlate (...not sure about the correspondent en:link...), has "most of the time" a wrong font size (bigger and bold).

Sometimes they goes away with a refresh. I've heard that on en:voy they have (had?) the same issue. They were talking to resolve it through JS but I don't think it's the right way.

Could you fix it?


Version: 1.22.0
Severity: normal
URL: http://it.wikivoyage.org/wiki/Africa

Details

Reference
bz51928

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:06 AM
bzimport set Reference to bz51928.
bzimport added a subscriber: Unknown Object (MLST).

Confirming on Firefox 22 when being logged in and Chrome 28 without being logged in.

Both are <h5>.

  • This bug has been marked as a duplicate of bug 51517 ***

Ryan, I'm pretty sure that it's just a coincidence, but after your patch, all the it:voy pages suffer a serious layout issue.

Several templated ceased to work, like Template:Avviso, Template:Pagebanner, Template:QuickbarCity Template:QuickbarCountry, ecc....

Could you check it and help me to understand where the problem is?

Thanks a lot

Furthermore I'd like to be informed when the problem will be fixed on the core software. As stated above, I don't like to have JS patches. Thanks

@Andyrom75: I believe the other problems are caused by the banner that is running on the site.

Nevermind, that's doesn't seem to be the source of the weirdness. It's definitely not coming from my CSS change though. I only changed CSS, not any of the site JS.

Furthermore I'd like to be informed

See the link in comment 2. The problem is already fixed in "core" software (though it's an extension), see bug 51517. For deployment of the fix on Wikimedia servers, see https://www.mediawiki.org/wiki/MediaWiki_1.22/Roadmap

@Ryan: I would agree with you because your patch should affect only a very restricted number of classes (div.portal h5), but yesterday night (Italian time) evreything worked perfectly, while this morning don't. No CSS file has been changed (according to the recent changes), your patch a part. That's why I'm asking you if you could support for a troubleshooting.

@Andre: I'm not sure to interprete correctly the info inside that link. The bug 51517 is listed in the 1.22wmf11 and it says that "Phase 2 Done" on Monday, July 22, 2013 .... so I would say that the patch can be removed immediately because the problem should have been already fixed. Isn't it?

PS I still haven't understood why your patch caused the above mentioned problem... If you have understood it let me know because it would be good to know.

No idea, but I fixed a JS race condition bug while I was troubleshooting:
https://it.wikivoyage.org/w/index.php?title=MediaWiki%3AApri-chiudi.js&diff=293745&oldid=269305

That should at least get rid of the JS errors that were happening on occasion.

Thanks.

In the past, to solve another issue as suggested by bugzilla guys, I've changed the use of hasClass because the one implemented in it:voy were using a wrong number of parameters.

I don't know if the issue that you have found on MediaWiki:Apri-chiudi.js can be solved in the same way (changing the input parameters) or if it's necessary to add a new class as you have just done.

PS Unfortunately I'm not able to find my previous open bug, so I can't tell you exactly which one it was.

(In reply to comment #13)

PS Unfortunately I'm not able to find my previous open bug, so I can't tell
you exactly which one it was.

https://bugzilla.wikimedia.org/buglist.cgi?emailreporter1=1&email1=andyrom75%40hotmail.com

The discussion gets offtopic for this bug report (which was about "wrong font size").

Thanks for the link.

Getting back on track on the bug, despite the 1.22wmf11 schedule , the problem on the sidebar is still present.

Upon Comment 15 I've forget to reopen the bug.

I checked again http://pl.wikivoyage.org/wiki/Afryka and http://uk.wikivoyage.org/wiki/%D0%90%D1%84%D1%80%D0%B8%D0%BA%D0%B0 but they all behave as expected and ship <h3>.

Wondering what's specific about it.wikivoyage.
I loaded the page while disabling all local JS and CSS, but no change.

singaporemaps wrote:

First key to the difference is that it.wikivoyage uses p-iproject instead of p-relatedsites unlike the other wikivoyages. Following that, code in Mediawiki:Vector.js and Mediawiki:Monobook.js:

$portal.addClass( 'portal' ).html( '<h5>Altri progetti</h5>' )

and elsewhere should be changed to h3 headings.

The CSS fix was always meant to be temporary until a bugzilla report was filed. Given that it caused so many unintended problems, it would probably be good to review the code for the Mediawiki Javascript files again.

PS. I like the star next to the interlanguage wikis signifying a star article. Where's the code for that?

Regarding the star article we use Template:Link V. But in these days we have a problem on that related to the bug 52874.

I've just applied the torty's suggested patch on Mediawiki:Vector.js and Mediawiki:Monobook.js and it seems to patch the issue.

But I agree with Torty when he says that the issue should be solved at the base and not through JS.

Appears fixed now; must have been a caching issue. Any local hacks should probably be checked and reverted now.