Page MenuHomePhabricator

ttmserver-export.php: Empty $mTitle in OutputPage::parse
Closed, ResolvedPublic

Description

maxsem@tin:/a/common$ mwscript extensions/Translate/scripts/ttmserver-export.php --wiki=metawiki

[snip]
18156 1623.97 25.0M Forked thread 20340 to handle Centralnotice-tgroup-B13_0724_mobile_dropdown_staged_enGB
Empty $mTitle in OutputPage::parse
Backtrace:
#0 /a/common/php-1.22wmf11/extensions/CentralNotice/includes/Banner.php(64): OutputPage->parse('{{MediaWiki:FR2...')
#1 /a/common/php-1.22wmf11/extensions/CentralNotice/includes/BannerMessageGroup.php(42): Banner->extractMessageFields()
#2 /a/common/php-1.22wmf11/extensions/Translate/messagegroups/MessageGroupOld.php(300): BannerMessageGroup->getDefinitions()
#3 /a/common/php-1.22wmf11/extensions/Translate/utils/MessageGroupStats.php(374): MessageGroupOld->initCollection('aa')
#4 /a/common/php-1.22wmf11/extensions/Translate/utils/MessageGroupStats.php(327): MessageGroupStats::calculateGroup(Object(BannerMessageGroup), 'aa')
#5 /a/common/php-1.22wmf11/extensions/Translate/utils/MessageGroupStats.php(265): MessageGroupStats::forItemInternal(Array, Object(BannerMessageGroup), 'aa')
#6 /a/common/php-1.22wmf11/extensions/Translate/utils/MessageGroupStats.php(114): MessageGroupStats::forGroupInternal(Object(BannerMessageGroup))
#7 /a/common/php-1.22wmf11/extensions/Translate/scripts/ttmserver-export.php(118): MessageGroupStats::forGroup('Centralnotice-t...')
#8 /a/common/php-1.22wmf11/extensions/Translate/scripts/ttmserver-export.php(84): TTMServerBootstrap->exportGroup(Object(BannerMessageGroup))
#9 /a/common/php-1.22wmf11/maintenance/doMaintenance.php(115): TTMServerBootstrap->execute()
#10 /a/common/php-1.22wmf11/extensions/Translate/scripts/ttmserver-export.php(166): require_once('/a/common/php-1...')
#11 /a/common/multiversion/MWScript.php(97): require_once('/a/common/php-1...')
#12 {main}

Very easy to repro on testwiki.


Version: master
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=52148

Details

Reference
bz51956

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:08 AM
bzimport set Reference to bz51956.

mwalker wrote:

This seems most likely to be a 'bug' in CentralNotice -- we are leveraging wgOut's parser instance instead of creating an instance for ourselves -- but apparently that has a dependency on being fully initialized which is not when in a maintenance script.

Is this blocking vanadium->zinc migration, is there a bug for that and is current priority appropriate for this report?

Change 75808 had a related patch set uploaded by Mwalker:
Banner Rendering to use the Parser Directly

https://gerrit.wikimedia.org/r/75808

Change 75808 merged by Adamw:
Banner Rendering to use the Parser Directly

https://gerrit.wikimedia.org/r/75808

Can someone confirm that this bug has been fixed?

mwalker wrote:

Works on my local; was going to deploy today.

mwalker wrote:

Testing on testwiki indicates it works. I'm just letting it finish up if you want to take its output.

mwalker wrote:

Actually; the script was running on metawiki; and it finished successfully at 10,000 seconds.

(In reply to comment #8)

Actually; the script was running on metawiki; and it finished successfully at
10,000 seconds.

That seems to have fixed bug 52148 too.