Page MenuHomePhabricator

Formatter: MobileFormatter doesn't wrap sections correctly
Closed, ResolvedPublic

Description

Author: jgonera

Description:
See https://es.m.wikipedia.org/wiki/Wikipedia:Caf%C3%A9/Archivo/T%C3%A9cnica/Actual

(this revision if it changed since reported: https://es.m.wikipedia.org/w/index.php?title=Wikipedia:Caf%C3%A9/Archivo/T%C3%A9cnica/Actual&oldid=68583002)

Even though the section "Crear mapas interactivos" is folded I can still see text below it because it is not wrapped in div.content_block.


Version: unspecified
Severity: normal

Details

Reference
bz51991

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:10 AM
bzimport set Reference to bz51991.
bzimport added a subscriber: Unknown Object (MLST).

Looks like this might have been caused by bad template HTML...

Is this a bug we should spend time on? On the one hand it's worrying an editor can create bad HTML that breaks the mobile site rendering, on the other hand it's good to showcase things that are broken so they get fixed...

Can't reproduce anymore, appears to have been fixed by our recent formatting overhaul.

As stated above it wasn't fixed by the overhaul but it seems to hint at unclosed DIV's generated by templates.... That said I'm not sure what we do here expect fix tidy... just wanted to point out it was NOT fixed by formatting overhaul - I can still replicate it.

  • Bug 55521 has been marked as a duplicate of this bug. ***

Max looks like we can duplicate this again:
On the mobile site for commons: https://commons.m.wikimedia.org/wiki/Commons:VP
has weird section collapsing. It has a whole bunch of sections grouped under
"September 24" (Like "October 08") even though they should be the same level as
"September 24"

Repro for this: https://commons.m.wikimedia.org/w/index.php?title=User:MaxSem/sandbox&oldid=107160980

The section formatter going berserk appears to be caused by an unclosed <div> at the end of September 24 section.

The ability to produce bad HTML seems very bad. Would it be feasible/controversial for the parser to notice this behaviour and close them when it reaches the end of the article / a section heading?

It's not a bad HTML neither from validator's POV, nor from parser's nor from end-user's - it's just our section wrapping that doesn't like it.

  • This bug has been marked as a duplicate of bug 55521 ***