gerrit stream-events reports older subject, not changed subject, when a new patchset is uploaded that changes the subject
Closed, DeclinedPublic
Actions

Assigned To

None

Authored By

	• MZMcBride
	Jul 25 2013, 8:43 AM

Description

There's a minor bug in grrrit-wm that goes something like this:

commit message is "foo"
user edits and submits commit message to be "bar"
when grrrit-wm reports new patchset, it reports "foo"

Yuvi says this is an upstream bug in Gerrit. This needs further investigation.

Version: unspecified
Severity: normal

Details

Reference: bz52016

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:45 AM

• bzimport added projects: Gerrit, Upstream.

• bzimport set Reference to bz52016.

• bzimport added a subscriber: Unknown Object (MLST).

• MZMcBride created this task.Jul 25 2013, 8:43 AM

From Yuvi:

{

"type": "patchset-created",
"change": {
    "project": "mediawiki/extensions/MassMessage",
    "branch": "master",
    "topic": "apiedit",
    "id": "Ib51f2f4a65a45d70e278c13c198733fd47bc3229",
    "number": "75299",
    "subject": "[WIP] Edit via the API",
    "owner": {
        "name": "Legoktm",
        "email": "legoktm.wikipedia@gmail.com",
        "username": "legoktm"
    },
    "url": "https://gerrit.wikimedia.org/r/75299",
    "status": "NEW"
},
"patchSet": {
    "number": "4",
    "revision": "5a10eb75f79055afca9f23f4195d068236d64515",
    "parents": [
        "3890db98317a855bca2645e5730f9e9404493f6b"
    ],
    "ref": "refs/changes/99/75299/4",
    "uploader": {
        "name": "MZMcBride",
        "email": "w@mzmcbride.com",
        "username": "mzmcbride"
    },
    "createdOn": 1374741950,
    "author": {
        "name": "Legoktm",
        "email": "legoktm.wikipedia@gmail.com",
        "username": "legoktm"
    },
    "sizeInsertions": 23,
    "sizeDeletions": -10
},
"uploader": {
    "name": "MZMcBride",
    "email": "w@mzmcbride.com",
    "username": "mzmcbride"
}

}{

"type": "comment-added",
"change": {
    "project": "mediawiki/extensions/MassMessage",
    "branch": "master",
    "topic": "apiedit",
    "id": "Ib51f2f4a65a45d70e278c13c198733fd47bc3229",
    "number": "75299",
    "subject": "[WIP] Edit via the MediaWiki Web API",
    "owner": {
        "name": "Legoktm",
        "email": "legoktm.wikipedia@gmail.com",
        "username": "legoktm"
    },
    "url": "https://gerrit.wikimedia.org/r/75299",
    "status": "NEW"
},
"patchSet": {
    "number": "4",
    "revision": "5a10eb75f79055afca9f23f4195d068236d64515",
    "parents": [
        "3890db98317a855bca2645e5730f9e9404493f6b"
    ],
    "ref": "refs/changes/99/75299/4",
    "uploader": {
        "name": "MZMcBride",
        "email": "w@mzmcbride.com",
        "username": "mzmcbride"
    },
    "createdOn": 1374741950,
    "author": {
        "name": "Legoktm",
        "email": "legoktm.wikipedia@gmail.com",
        "username": "legoktm"
    },
    "sizeInsertions": 23,
    "sizeDeletions": -10
},
"author": {
    "name": "jenkins-bot",
    "username": "jenkins-bot"
},
"approvals": [
    {
        "type": "Verified",
        "description": "Verified",
        "value": "1"
    }
],
"comment": "Patch Set 4: Verified+1\n\nBuild succeeded.\n\n- https://integration.wikimedia.org/ci/job/mwext-MassMessage-lint/38/console : SUCCESS in 0s"

}

(In reply to comment #1)
comment-added subject is fine; patchset-created subject is wrong.

Bug 54372 is likely a duplicate of this bug report. This issue may be fixed.

Bug 54372 has been marked as a duplicate of this bug. ***

• Phabricator_maintenance removed a subscriber: yuvipanda.Jun 7 2017, 7:02 PM

gerrit stream-events reports older subject, not changed subject, when a new patchset is uploaded that changes the subjectClosed, DeclinedPublicActions

Description

Details

Event Timeline

gerrit stream-events reports older subject, not changed subject, when a new patchset is uploaded that changes the subject
Closed, DeclinedPublic
Actions