Page MenuHomePhabricator
Create Task
Maniphest T54049

Mobile editor silently fails when abusefilter is triggered
Closed, ResolvedPublic
Actions

Description

Author: jgonera

Description:
Mobile editor fails if a given wiki uses abusefilter. An example is plwiki. I couldn't reproduce it all the times, but half of the times when trying to edit the API returned an abusefilter message saying that I was removing a lot of text (even though I was removing a single word) and the edit failed. It seemed that the second attempt would usually succeed.

Unfortunately, as it is now, when this happens the editor will show a success message and close, but will not save anything, making the user lose their changes.

This is similar to bug 52047, however the fix is not the same.

Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=52077

Details

Reference
bz52049

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:48 AM
• bzimport added a project: MobileFrontend-stable.
• bzimport set Reference to bz52049.
• bzimport added a subscriber: Unknown Object (MLST).
• bzimport created this task.Jul 25 2013, 7:24 PM
• bzimport added a comment.Jul 26 2013, 12:25 AM

jgonera wrote:

Request that triggered abusefilter

The edit was only adding a dot after the last sentence.

Attached:

plwiki-abusefilter-request.txt2 KBDownload

• bzimport added a comment.Jul 26 2013, 12:26 AM

jgonera wrote:

Response from the abusefilter

The message says that I removed a lot of text and if I'm sure what I'm doing. It tells me to hit Save again if I do.

Attached:

plwiki-abusefilter-response.json1 KBDownload

• bzimport added a comment.Jul 26 2013, 12:29 AM

jgonera wrote:

Trying to edit again (same edit, adding a dot), succeeds. This means that a possible solution would be to show the Save button again when we receive an abusefilter message. We need to show the message too, although it's tricky because it's in horrible HTML format (see attachment; should we just strip HTML?).

• bzimport added a comment.Jul 26 2013, 12:41 AM

jgonera wrote:

Response from the abusefilter (eswiki)

I've just run into that on eswiki too.

Attached:

eswiki-abusefilter-response.json1 KBDownload

Krenair added a comment.Jul 26 2013, 8:06 AM

(In reply to comment #0)

half of the times when trying to edit
the API returned an abusefilter message saying that I was removing a lot of
text (even though I was removing a single word) and the edit failed.

This might not be a mobile-specific problem - see bug 52077

• bzimport added a comment.Jul 26 2013, 6:18 PM

jgonera wrote:

That may solve the problem of getting an abusefilter message about removing a lot of text when making small changes, but we still need to implement abusefilter messages on mobile.

gerritbot added a comment.Jul 26 2013, 11:18 PM

Change 76215 had a related patch set uploaded by JGonera:
Show error message on CAPTCHAs and extension errors

https://gerrit.wikimedia.org/r/76215

gerritbot added a comment.Jul 27 2013, 3:57 PM

Change 76215 merged by jenkins-bot:
Show error message on CAPTCHAs and extension errors

https://gerrit.wikimedia.org/r/76215

• bzimport added a comment.Jul 29 2013, 12:04 AM

jgonera wrote:

I'm not sure if we should mark this fixed. This should still be implemented.

gerritbot added a comment.Jul 29 2013, 9:59 PM

Change 76633 had a related patch set uploaded by MaxSem:
Show error message on CAPTCHAs and extension errors

https://gerrit.wikimedia.org/r/76633

gerritbot added a comment.Jul 29 2013, 10:02 PM

Change 76633 merged by jenkins-bot:
Show error message on CAPTCHAs and extension errors

https://gerrit.wikimedia.org/r/76633

• bzimport added a comment.Jul 29 2013, 10:26 PM

mgrover wrote:

Max deployed this today and I tested looks good.

• bzimport added a comment.Sep 16 2013, 9:48 PM

mgrover wrote:

Max added additional error messaging but the issue still exists so reopening.

Jdlrobson added a comment.Oct 8 2013, 11:36 PM

Juliusz is working on this as part of story:
https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1269

Jdlrobson added a comment.Oct 16 2013, 1:22 AM

https://gerrit.wikimedia.org/r/88899

gerritbot added a comment.Oct 16 2013, 9:26 PM

Change 88899 had a related patch set uploaded by JGonera:
Story 1269: AbuseFilter support

https://gerrit.wikimedia.org/r/88899

gerritbot added a comment.Oct 16 2013, 9:57 PM

Change 88899 merged by jenkins-bot:
Story 1269: AbuseFilter support

https://gerrit.wikimedia.org/r/88899

He7d3r mentioned this in T54077: APIEditBeforeSave isn't replacing sections like the documentation claims.Apr 7 2016, 11:37 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL