Page MenuHomePhabricator

Use some local settings file for rt-server server.js
Closed, ResolvedPublic

Description

Maybe make the time to wait between retries a commandline parameter? That way, we can play with that value without requiring new code commits. For example, 5 mins. maybe more than enough time to wait between retries.

Another thing to consider is add an equivalent of server.settings.js file for server config with db info, and settings like this.


Version: unspecified
Severity: normal

Details

Reference
bz52114

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:53 AM
bzimport added a project: Parsoid-Tests.
bzimport set Reference to bz52114.

Seems easy enough, at least adding the command line parameters. If both command line and settings file are present, though, which one should take priority?

commandline takes priority. settings file provides sensible defaults for the install which you can override temporarily via the commandline.

Change 76754 had a related patch set uploaded by Marcoil:
Use a local settings file for rt-test server.js, add more options.

https://gerrit.wikimedia.org/r/76754

Change 76754 merged by jenkins-bot:
Use a local settings file for rt-test server.js, add more options.

https://gerrit.wikimedia.org/r/76754

Fix is in rt_testing branch, reopen if more work is necessary before merging into master.