Page MenuHomePhabricator
Create Task
Maniphest T54120

browsertests: triggers for ULS
Closed, ResolvedPublic
Actions

Description

This makes sense for ULS because they have a reasonable number of merges in a day, see https://gerrit.wikimedia.org/r/#/q/status:merged+project:mediawiki/extensions/UniversalLanguageSelector,n,z

This would entail:

  • Put the ULS tests into their own Jenkins build, and possibly into their own code repo the way Mobile is
  • Have Jenkins kick off the build of ULS tests targeting beta labs upon code merged in the ULS branch
  • Report the build status after each run

This came up because we found Bug 52115 in a timely way.

Version: unspecified
Severity: enhancement
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=52890
https://bugzilla.wikimedia.org/show_bug.cgi?id=53691
https://bugzilla.wikimedia.org/show_bug.cgi?id=57560

Details

Reference
bz52120

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 1:53 AM
• bzimport added a project: Continuous-Integration-Infrastructure.
• bzimport set Reference to bz52120.
• Cmcmahon created this task.Jul 26 2013, 9:47 PM
zeljkofilipin added a comment.Aug 30 2013, 10:56 AM

Is this still something we want to do? ULS tests are now in ULS repo, so this should be doable. The only problem is that ULS tests are not stable enough:

https://wmf.ci.cloudbees.com/view/r-uls/

hashar added a comment.Aug 30 2013, 3:45 PM

What about running the tests on patch submission?

Jdforrester-WMF added a comment.Sep 2 2013, 9:22 PM

Have added bug 53691 for the same for the VisualEditor repo.

hashar added a comment.Sep 25 2013, 12:41 PM

Moving this under Continuous Integration radar.

hashar added a comment.Nov 25 2013, 11:43 AM

Following a pair session with Željko, the tests can be flagged with a tag which we can then exclude when running tests. For ULS, I have introduced the tag @specific-settings which let us skip any tests that are not going to pass on a fresh wiki installation: https://gerrit.wikimedia.org/r/#/c/97487/

hashar added a comment.Nov 25 2013, 8:49 PM

The browser tests manage to pass with above change:

https://integration.wikimedia.org/ci/job/mwext-browsertests-UniversalLanguageSelector-phantomjs/27/consoleFull

With a nice HTML report:
https://integration.wikimedia.org/ci/job/mwext-browsertests-UniversalLanguageSelector-phantomjs/27/artifact/report.html

Whenever the change in comment #5 is merged in, I will validate with i18n team how to get it triggered by Zuul.

gerritbot added a comment.Nov 26 2013, 2:54 PM

Change 97741 had a related patch set uploaded by Hashar:
ULS browsertests on check pipeline

https://gerrit.wikimedia.org/r/97741

gerritbot added a comment.Nov 26 2013, 2:55 PM

Change 97741 merged by jenkins-bot:
ULS browsertests on check pipeline

https://gerrit.wikimedia.org/r/97741

hashar added a comment.Nov 27 2013, 5:46 PM

The trigger has been added in Zuul with https://gerrit.wikimedia.org/r/97741

The job will success whenever ULS change https://gerrit.wikimedia.org/r/#/c/97487/ is merged in.

hashar added a comment.Dec 6 2013, 1:56 PM

The job got fixed yesterday and browser tests are passing right now. It is not blocking changes yet though.

hashar mentioned this in T59560: browsertests: triggers for MobileFrontend.Mar 24 2015, 2:45 PM
hashar mentioned this in T75364: Run subset of Wikidata browsertests on every commit on Gerrit..Mar 24 2015, 2:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL