Page MenuHomePhabricator

Gerrit bot doesn't update Bugzilla if there are blank lines between the "Bug:" and "Change-Id" keywords
Closed, DeclinedPublic

Description

If I manually add "Bug: XXXX" to a commit message via the Gerrit commit message user interface editor, the Gerrit–Bugzilla bot doesn't notice and doesn't update the bug appropriately.

Examples related to bug 52056:


Version: wmf-deployment
Severity: normal

Details

Reference
bz52132

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:54 AM
bzimport added a project: Gerrit.
bzimport set Reference to bz52132.
bzimport added a subscriber: Unknown Object (MLST).

It does in my experience, but you can't have empty lines between "Bug:" and "Change-Id:".

(In reply to comment #1)

It does in my experience, but you can't have empty lines between "Bug:" and
"Change-Id:".

Ahh. Weird. Updating bug summary to reflect this.

I'm pretty sure that this happens whichever way you edit the commit message.

Krinkle claimed this task.

Meta data such as headers and footers should not have empty lines among them. The first empty line denotes the end of the header and start of the body. The last empty line denotes the start of the footer. Adding an empty line between Bug and Change-Id makes the bug reference an odd paragraph in the body.

See also https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines.