Page MenuHomePhabricator

Browser tests for guided tours being delivered by the GettingStarted toolbar
Closed, DeclinedPublic

Description

There should be browser tests for the tours launched from the GettingStarted tooolbar. These are 'gettingstartedtasktoolbar' and 'gettingstartedtasktoolbarve'.


Version: unspecified
Severity: normal

Details

Reference
bz52246

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:02 AM
bzimport set Reference to bz52246.
bzimport added a subscriber: Unknown Object (MLST).

Is this still desired? We had such tests at one time but they became irrelevant after a lot of A/B testing as I recall, and we did not replace them.

Yes, these tours are being actively delivered, and there are no plans to remove them.

I think we should probably implement these ourselves, in the GettingStarted repo, so we can develop some team Cucumber knowledge.

Matthew, would you like to pair with me on this?

It's not assigned or scheduled yet, but I think we would appreciate that later.

Just ping me when you are ready. :)

swalling wrote:

(In reply to Matthew Flaschen from comment #3)

I think we should probably implement these ourselves, in the GettingStarted
repo, so we can develop some team Cucumber knowledge.

I'd also love to learn how to do write these.

(In reply to Steven Walling from comment #7)

I'd also love to learn how to do write these.

Pair programming for fun and profit FTW! :)

https://www.mediawiki.org/wiki/Pair_programming_for_fun_and_profit

Change 123873 had a related patch set uploaded by Zfilipin:
Added files needed for Selenium tests

https://gerrit.wikimedia.org/r/123873

Chris and I have paired on the first test, it is not finished. Who would like to pair with Chris or me to finish the test? :)

Change 144978 had a related patch set uploaded by Zfilipin:
WIP The first GettingStarted test

https://gerrit.wikimedia.org/r/144978

Change 150172 had a related patch set uploaded by Zfilipin:
WIP Enable browser tests for the GettingStarted extension

https://gerrit.wikimedia.org/r/150172

Change 152795 had a related patch set uploaded by Zfilipin:
WIP Running Ruby linter for GettingStarted

https://gerrit.wikimedia.org/r/152795

Change 144978 merged by jenkins-bot:
The first GettingStarted test

https://gerrit.wikimedia.org/r/144978

Change 156510 had a related patch set uploaded by Hashar:
Ruby linter for GettingStarted

https://gerrit.wikimedia.org/r/156510

Change 152795 merged by jenkins-bot:
Running Ruby linter for GettingStarted

https://gerrit.wikimedia.org/r/152795

Change 156510 merged by jenkins-bot:
Ruby linter for GettingStarted

https://gerrit.wikimedia.org/r/156510

Created attachment 16290
password field is not filled properly

Jenkins / Zuul have now been configured.

The first build of the browser test (https://integration.wikimedia.org/ci/job/browsertests-GettingStarted-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/1/ ) fails though:

Scenario: User sees modal call to action after registration # features/modal_on_editable_returnto.feature:4
Given I have just registered # features/step_definitions/modal_on_editable_returnto_steps.rb:1

timed out after 10 seconds, waiting for {:id=>"pt-logout", :tag_name=>"li"} to become present (Watir::Wait::TimeoutError)

The password field was left empty (see attachment). I guess the job defined by https://gerrit.wikimedia.org/r/#/c/150172/ is missing something.

Attached:

Modal_on_editable_returnto_page-_User_sees_modal_call_to_action_after_registration.png (775×1 px, 89 KB)

This test has nothing to do with the toolbar guided tours. Please use bug 63172 for the modal/CTA tests.

Does this still need to be implemented, or can this task be resolved?

Mattflaschen-WMF lowered the priority of this task from Medium to Low.Nov 6 2015, 1:17 AM

There is no team that officially works on GettingStarted, so it's a low priority.

MediaWiki-extensions-GettingStarted has been removed from Wikimedia wikis and is getting archived per T292654. Thus declining this task to reflect reality.

See e.g. GrowthExperiments-NewcomerTasks or #GuidedTour instead nowadays for related use cases.