Page MenuHomePhabricator

Obsolete scripts in /usr/local/bin need to be "managed"
Closed, ResolvedPublic

Description

The tool afch-updater had hard-coded /usr/*local*/bin/jsub (which was the advertised location, so no blame here); on tools-webserver-01 that was an obsolete version of jsub with bugs. I fixed that by replacing the grid scripts with symlinks to /usr/bin.

We should manage the compatibility symlinks (I'm fine with removal as well) in /usr/local/bin on the *whole* cluster properly with Puppet, or place small wrappers there that log the caller program's name and user, and then pass the arguments to the "normal" scripts, so that we can track down people using the old location.

On tools-webserver-01, the following files are in /usr/local/bin *and* in /usr/bin:

check-raid.py
cpan
cygdb
cython
job
jstart
jstop
jsub

Version: unspecified
Severity: normal

Details

Reference
bz52258

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:03 AM
bzimport added a project: Toolforge.
bzimport set Reference to bz52258.

Second thought regarding wrappers: /usr/local/bin has priority in many PATHs, so if we put a wrapper in there, it may be preferred over the "original" in /usr/bin, so the wrapper would have to do a lot of guesswork to determine if a user really called the wrong script.

Proposal: Put symlinks in Puppet, advise users on labs-l to check PATHs and absolute paths by ... end of September (vacation season in the northern hemisphere ATM), then "ensure => absent", then remove Puppet section.

Change 77234 had a related patch set uploaded by Tim Landscheidt:
Tools: Manage obsolete files in /usr/local/bin

https://gerrit.wikimedia.org/r/77234

Change 77234 merged by coren:
Tools: Manage obsolete files in /usr/local/bin

https://gerrit.wikimedia.org/r/77234

Reopening for "advise users on labs-l to check PATHs and absolute paths by ... end of September (vacation season in the northern hemisphere ATM), then "ensure => absent", then remove Puppet section." with September replaced by ... let's say April.

Change 115612 had a related patch set uploaded by Tim Landscheidt:
Tools: Restore local symlinks for jobutils

https://gerrit.wikimedia.org/r/115612

Change 115612 abandoned by Tim Landscheidt:
Tools: Restore local symlinks for jobutils

https://gerrit.wikimedia.org/r/115612

Cf. Gerrit change #115612; users advised per http://permalink.gmane.org/gmane.org.wikimedia.labs/2140, "ensure => absent" will be done by data center move.