Page MenuHomePhabricator

The on-page Flagged Revisions notice about transcluded files or templates having outstanding changes doesn't appear in the edit notices
Closed, ResolvedPublic

Description

When a page has pending edits and it is opened for editing using VisualEditor, there is a dropdown box with a notice about this. When a page has a template or a file with pending changes is opened for editing, the dropdown box does not appear.

An example on the Russian Wikipedia:
https://ru.wikipedia.org/wiki/%D0%98%D1%80%D0%B3%D0%B8%D1%88


Version: unspecified
Severity: enhancement
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=52440

Details

Reference
bz52280

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:04 AM
bzimport set Reference to bz52280.

Specifically, not only does the dropdown box not appear, but the notice that was on the page before clicking "edit" disappears, leaving absolutely no notice.

Yes, this is intentional (as the tool interferes with VisualEditor and will need re-writing/merging into VE to work properly).

The notice above the page having transcluded files or templates with outstanding changes feels like one of the things that should appear in the wikitext page's edit notices (and so on VisualEditor's panel too) - not sure why it doesn't. Is this a Pending Changes bug?

Shouldn't this appear on the wikitext editor too then?

Change 123875 had a related patch set uploaded by Alex Monk:
Show pending changes notice about unstable transclusions in VE

https://gerrit.wikimedia.org/r/123875

(In reply to Alex Monk from comment #3)

Shouldn't this appear on the wikitext editor too then?

Maybe create a further bug for that in FlaggedRevisions?

(In reply to James Forrester from comment #5)

(In reply to Alex Monk from comment #3)

Shouldn't this appear on the wikitext editor too then?

Maybe create a further bug for that in FlaggedRevisions?

I just noticed that it was already made - by you. And it's what this bug is marked as depending on.

(In reply to Alex Monk from comment #6)

(In reply to James Forrester from comment #5)

(In reply to Alex Monk from comment #3)

Shouldn't this appear on the wikitext editor too then?

Maybe create a further bug for that in FlaggedRevisions?

I just noticed that it was already made - by you. And it's what this bug is
marked as depending on.

Ha. Never mind me. :-)

Jdforrester-WMF renamed this task from VisualEditor: The on-page Flagged Revisions notice about transcluded files or templates having outstanding changes doesn't appear in the edit notices to The on-page Flagged Revisions notice about transcluded files or templates having outstanding changes doesn't appear in the edit notices.Jan 23 2015, 7:38 PM
Jdforrester-WMF set Security to None.

Change 123875 merged by jenkins-bot:
Show pending changes notice about unstable transclusions in VE

https://gerrit.wikimedia.org/r/123875

Jdforrester-WMF removed subscribers: gerritbot, Unknown Object (MLST).