Page MenuHomePhabricator

Wrong language in html emails
Closed, ResolvedPublic

Description

HTML emails for notifications was enabled today on English Wikipedia. The "View Post View Changes" links were in Dutch on the email I received. ("Bericht bekijken Wijzigingen bekijken")


Version: unspecified
Severity: normal

Details

Reference
bz52298

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:05 AM
bzimport added a project: Notifications.
bzimport set Reference to bz52298.

Hi Risker, thanks for reporting this issue. At this time, we cannot reproduce it on our end. Could you please upload a screenshot and a URL to the specific 'View Change' message which caused a Dutch version of the diff to appear? There are no copyright issues with posting the screenshot, as our designs are all CC-BY-SA 3.0. Also, if you are uncomfortable sharing any information in public, you are welcome to email it to me directly at fflorin-at-wikimedia.org. Did you by any chance visit the Dutch Wikipedia recently, or select the Dutch language in any of our language selectors? We want to get to the bottom of this issue, and would like to find out steps that would allow us to reproduce it. Thanks in advance for any tips you can provide to help us solve this issue for you.

(In reply to comment #1)

Hi Risker, thanks for reporting this issue. At this time, we cannot reproduce
it on our end. Could you please upload a screenshot and a URL to the specific
'View Change' message which caused a Dutch version of the diff to appear?

I have a screenshot which I will email to you.

There
are no copyright issues with posting the screenshot, as our designs are all
CC-BY-SA 3.0. Also, if you are uncomfortable sharing any information in
public,
you are welcome to email it to me directly at fflorin-at-wikimedia.org.

Please keep in mind that Enwp convention is that emails are copyrighted by the sender and may not be published on enwp without the authorization of the sender. We're very strict about emails being published, for reasons that have nothing to do with this.

Did

you
by any chance visit the Dutch Wikipedia recently, or select the Dutch
language
in any of our language selectors? We want to get to the bottom of this issue,
and would like to find out steps that would allow us to reproduce it. Thanks
in
advance for any tips you can provide to help us solve this issue for you.

Was on the Dutch Wikipedia once in the past week to read only, have been on at least six other language Wikipedias since then to read. I have never set preferences for anything other than English anywhere on WMF sites or through my email. Please note my further comment that the second message (the one I'll send you a screenshot for) even has the message garbled.

Can you attach the screenshot to this bug? I suspect the notification was generated by a user whose user language is Dutch.

bsitu wrote:

Yeah, we should set the language to the user's selected language

kwwilliams wrote:

I can confirm that that message was from a user who has his default interface language set to Dutch.

Change 76874 had a related patch set uploaded by Bsitu:
(bug 52298) The email should be set in the user's language

https://gerrit.wikimedia.org/r/76874

(In reply to comment #4)

Yeah, we should set the language to the user's selected language

Well, it *is* in the user's selected language - the sender's. What you want is to set it to the selected language of the recipient user.

bsitu wrote:

(In reply to comment #7)

(In reply to comment #4)

Yeah, we should set the language to the user's selected language

Well, it *is* in the user's selected language - the sender's. What you want
is
to set it to the selected language of the recipient user.

Sorry about the confusion, what I meant by user is the recipient

Change 76874 had a related patch set uploaded by Alex Monk:
(bug 52298) The email should be set in the user's language

https://gerrit.wikimedia.org/r/76874

Change 76874 merged by jenkins-bot:
The email should be sent in the recipient's language

https://gerrit.wikimedia.org/r/76874

Thanks, Alex, Benny and kww, much appreciated.

Risker, we were already aware of the weird characters issue (e.g.: ' & # 8226 ; '), which is triggered by HTML codes like the '< font >' tag.

I have filed this bug #52313, so we can solve that issue as soon as possible.

https://bugzilla.wikimedia.org/show_bug.cgi?id=52313

Both of these bugs have a high priority, and we will do our best to deploy them this week if we can.