Page MenuHomePhabricator
Create Task
Maniphest T54321

the message diff-multi above comparison of several revisions has wrong directionality
Closed, ResolvedPublic
Actions

Description

To reproduce:

  1. Go to https://www.wikidata.org/w/index.php?title=Q12060906&diff=56007681&oldid=53789438&uselang=he
  1. Inspect the message above the diff - (7 גרסאות ביניים של 6 משתמשים אינן מוצגות).

Observed: The CSS property direction is "ltr".

Expected: The CSS property direction must be "rtl", because it's Hebrew.

I suspect that it happens because the function that adds this message uses getPageLanguage, while it should use the user language, but I didn't test too deeply.

Details

Reference
bz52321
SubjectRepoBranchLines +/-
wdqs: Add and replace hostsoperations/puppetproduction+27 -30
rdf-streaming-updater: New docker image and jemalloc configoperations/deployment-chartsmaster+4 -12
elastic: increment BUILD_VERSIONoperations/software/elasticsearch/pluginsmaster+1 -1
Fix updateButton not getting activated on NumberInput changemediawiki/extensions/ProofreadPagemaster+3 -0
Short subject linemediawiki/extensions/examplesmaster+2 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:07 AM
• bzimport added projects: MediaWiki-extensions-WikibaseRepository, I18n, patch-welcome.
• bzimport set Reference to bz52321.
Amire80 created this task.Jul 31 2013, 12:07 PM
gerritbot added a comment.Aug 16 2013, 11:14 AM

Change 79326 had a related patch set uploaded by Amire80:
Add diff-multi to classes with explicit direction

https://gerrit.wikimedia.org/r/79326

gerritbot added a comment.Aug 20 2013, 8:51 AM

Change 79326 merged by jenkins-bot:
Add diff-multi to classes with explicit direction

https://gerrit.wikimedia.org/r/79326

gerritbot subscribed.Mar 12 2016, 11:14 AM

Change 276951 had a related patch set uploaded (by Vaishali Jain):
Change Special:Tags to OOUI

https://gerrit.wikimedia.org/r/276951

Restricted Application added a project: Wikidata. · View Herald TranscriptMar 12 2016, 11:14 AM
gerritbot added a project: Patch-For-Review.Mar 12 2016, 11:14 AM
gerritbot added a comment.Feb 1 2017, 11:48 AM

Change 335431 had a related patch set uploaded (by Nikssardana):
Short subject line

https://gerrit.wikimedia.org/r/335431

gerritbot added a comment.Feb 1 2017, 12:16 PM

Change 335431 abandoned by Amire80:
Short subject line

Reason:
Looks like a mistake.

https://gerrit.wikimedia.org/r/335431

matej_suchanek removed a project: Patch-For-Review.Feb 5 2017, 9:49 AM
matej_suchanek updated the task description. (Show Details)
matej_suchanek removed a subscriber: Wikidata-bugs.
gerritbot added a comment.May 6 2017, 10:16 AM

Change 352321 had a related patch set uploaded (by Jobodobo; owner: Jobodobo):
[mediawiki/extensions/examples@master] This is BUG: T54321

https://gerrit.wikimedia.org/r/352321

gerritbot added a project: Patch-For-Review.May 6 2017, 10:16 AM
Paladox removed a project: Patch-For-Review.May 6 2017, 10:53 AM
Paladox removed a subscriber: gerritbot.
gerritbot added a comment.May 6 2017, 12:25 PM

Change 352321 abandoned by Jobodobo:
This is BUG: T54321

https://gerrit.wikimedia.org/r/352321

gerritbot added a comment.Sep 5 2017, 8:17 PM

Change 376091 had a related patch set uploaded (by Dmaza; owner: Dmaza):
[mediawiki/extensions/AbuseFilter@master] Fix confusing warning message on throtthled filters

https://gerrit.wikimedia.org/r/376091

gerritbot added a project: Patch-For-Review.Sep 5 2017, 8:17 PM
gerritbot added a comment.Sep 8 2020, 5:44 PM

Change 625946 had a related patch set uploaded (by Sohom Datta; owner: Sohom Datta):
[mediawiki/extensions/ProofreadPage@master] Fix updateButton not getting activated on NumberInput change

https://gerrit.wikimedia.org/r/625946

gerritbot added a comment.Sep 9 2020, 1:44 AM

Change 625946 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] Fix updateButton not getting activated on NumberInput change

https://gerrit.wikimedia.org/r/625946

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.9; 2020-09-15).Sep 9 2020, 2:00 AM
gerritbot added a comment.Nov 21 2021, 3:21 PM

Change 740334 had a related patch set uploaded (by Sohom Datta; author: Sohom Datta):

[mediawiki/extensions/ProofreadPage@master] OSD: Prevent original image from getting overwritten by OSD

https://gerrit.wikimedia.org/r/740334

matej_suchanek removed a project: Patch-For-Review.Nov 22 2021, 8:56 AM
gerritbot added a comment.Apr 4 2022, 9:50 PM

Change 776999 had a related patch set uploaded (by Bking; author: Bking):

[operations/software/spicerack@master] elastic: don't wait for green on first node in cluster

https://gerrit.wikimedia.org/r/776999

gerritbot added a project: Patch-For-Review.Apr 4 2022, 9:50 PM
gerritbot added a comment.Apr 18 2022, 2:06 PM

Change 783848 had a related patch set uploaded (by Bking; author: Bking):

[operations/puppet@production] Elastic: use major version only for 'config_version'

https://gerrit.wikimedia.org/r/783848

gerritbot added a comment.Jun 8 2022, 10:04 PM

Change 803996 had a related patch set uploaded (by Bking; author: Bking):

[operations/software/elasticsearch/plugins@master] elastic: increment BUILD_VERSION

https://gerrit.wikimedia.org/r/803996

gerritbot added a comment.Jun 8 2022, 10:15 PM

Change 803996 merged by Bking:

[operations/software/elasticsearch/plugins@master] elastic: increment BUILD_VERSION

https://gerrit.wikimedia.org/r/803996

gerritbot added a comment.May 31 2023, 2:21 PM

Change 924958 had a related patch set uploaded (by Bking; author: Bking):

[operations/deployment-charts@master] rdf-streaming-updater: New docker image and jemalloc config

https://gerrit.wikimedia.org/r/924958

gerritbot added a comment.May 31 2023, 2:23 PM

Change 924958 merged by jenkins-bot:

[operations/deployment-charts@master] rdf-streaming-updater: New docker image and jemalloc config

https://gerrit.wikimedia.org/r/924958

gerritbot added a comment.Jun 29 2023, 7:14 PM

Change 934403 had a related patch set uploaded (by Bking; author: Bking):

[operations/puppet@production] wdqs: Add and replace hosts

https://gerrit.wikimedia.org/r/934403

gerritbot added a comment.Jun 29 2023, 7:29 PM

Change 934403 merged by Bking:

[operations/puppet@production] wdqs: Add and replace hosts

https://gerrit.wikimedia.org/r/934403

gerritbot added a comment.Sep 22 2023, 3:38 PM

Change 960087 had a related patch set uploaded (by Bking; author: Bking):

[operations/deployment-charts@master] dse-k8s: Trigger flink-app savepoint

https://gerrit.wikimedia.org/r/960087

gerritbot added a comment.Sep 22 2023, 5:33 PM

Change 960114 had a related patch set uploaded (by Bking; author: Bking):

[operations/puppet@production] cloudelastic: new partman recipe

https://gerrit.wikimedia.org/r/960114

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL