in tables an empty bgcolor attribute is parsed suboptimally
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Thryduulf
	Jul 31 2013, 6:02 PM

Description

Compare the first two cells in row 1 of the table at https://en.wikipedia.org/w/index.php?title=User:Thryduulf/sandbox&oldid=566470353#Table where the Wikicode

-
bgcolor=""	row 1, cell 1
bgcolor	row 1, cell 2

produces:

Row 1 cell 1 is rendered with the light grey background colour defined in the wikitable class. Row 1 cell 2 is rendered with a dark red background colour (#b00000)

The desired behaviour is that both should produce the html <td bgcolor="">

Version: unspecified
Severity: normal

Details

Reference: bz52330

	Subject	Repo	Branch	Lines +/-
	Empty attribute syntax	mediawiki/core	master	+19 -12

Customize query in gerrit

Related Objects

Mentioned In: rGPARc68b60708972: Sync parserTests with core.
T53954: empty attribute should be discarded
rMWaee072efe2f6: Empty attribute syntax

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:08 AM

• bzimport added a project: MediaWiki-Parser.

• bzimport set Reference to bz52330.

• bzimport added a subscriber: Unknown Object (MLST).

Thryduulf created this task.Jul 31 2013, 6:02 PM

From Sanitizer::getTagAttributeCallback:

In XHTML, attributes must have a value.
For 'reduced' form, return explicitly the attribute name here.

Works as aspected, but it the aspected right?

That behaviour might be what is expected from the code specification, but the output it isn't what the end user expects.

This is causing a difference vs. Parsoid, so it would be good to fix this in PHP. See also bug 51954.

duplicatebug unsubscribed.Dec 13 2014, 11:49 AM

Change 223346 had a related patch set uploaded (by Arlolra):
Empty attribute syntax

https://gerrit.wikimedia.org/r/223346

gerritbot added a project: Patch-For-Review.Jul 7 2015, 4:55 PM

Change 223346 merged by jenkins-bot:
Empty attribute syntax

https://gerrit.wikimedia.org/r/223346

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 3 2015, 11:07 PM

Arlolra mentioned this in rMWaee072efe2f6: Empty attribute syntax.Aug 3 2015, 11:07 PM

• Forrestbot added projects: MW-1.26-release, WMF-deploy-2015-08-04_(1.26wmf17).Aug 4 2015, 12:00 AM

Arlolra closed this task as Resolved.Aug 4 2015, 12:45 AM

Arlolra claimed this task.

Arlolra mentioned this in T53954: empty attribute should be discarded.Aug 4 2015, 1:55 AM

cscott mentioned this in rGPARc68b60708972: Sync parserTests with core..Aug 4 2015, 5:26 PM

in tables an empty bgcolor attribute is parsed suboptimallyClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

in tables an empty bgcolor attribute is parsed suboptimally
Closed, ResolvedPublic
Actions