mw.msg should not return an error message if the message contains '{{SomeTemplate}}'
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	He7d3r
	Aug 2 2013, 8:18 PM

Description

If mw.loader.getState( 'mediawiki.jqueryMsg' ) is not 'ready', and I execute the code

mw.messages.set( {
    'some-key': 'SomeText {{SomeTemplate}}.'
} ); 
alert( mw.msg( 'some-key' ) );

I get 'SomeText {{SomeTemplate}}.' as expected.

But if I enable any gadget which loads the module 'mediawiki.jqueryMsg', and run the same code again, the result unexpectedly changes to 'some-key: Unknown operation "sometemplate"'.

It should still be 'SomeText {{SomeTemplate}}.', because there is no magic word called 'SomeTemplate'

Details

Reference: bz52479

Related Objects

Mentioned In: T44107: wikieditor-toolbar-help-content-signaturetimestamp-result: Parse error at position 19 in input:
T51951: Window title for "Creating" should support parser functions

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 1:48 AM

• bzimport added projects: MediaWiki-JavaScript, JavaScript.

• bzimport set Reference to bz52479.

• bzimport added a subscriber: Unknown Object (MLST).

He7d3r created this task.Aug 2 2013, 8:18 PM

Templates are not currently supported in jQueryMsg, just magic words (the code uses the word 'template' to mean magic words).

mw.msg is equivalent to mw.message(...).text()

meaning the 'text' format/operation is being used.

In the PHP parser's text mode, if a template exists, it is expanded into its wikitext. If it does not exist, it results in [[:Template:SomeTemplate]].

With the way jQueryMsg currently works, even checking if the template existed would require either:

Sending extra data down from ResourceLoader
Doing an API call from jQueryMsg

Thus, for now I recommend you use:

mw.message( 'some-key' ).plain()

if you want the output 'SomeText {{SomeTemplate}}.' for this kind of thing.

The 'plain' format does not try to expand {{ }} blocks, just $1, $2 replacement.

Undoing my title change

Change 113307 had a related patch set uploaded by Bartosz Dziewoński:
mediawiki.jqueryMsg: Don't throw parse errors in the user's face

https://gerrit.wikimedia.org/r/113307

The above patch sorta kinda addresses this by hiding the user-visible error messages.

matmarex edited projects, added I18n, MediaWiki-Internationalization; removed MediaWiki-JavaScript.Dec 21 2014, 5:07 PM

• Mattflaschen-WMF unsubscribed.Jan 13 2015, 1:13 AM

matmarex updated the task description. (Show Details)Apr 10 2015, 4:43 PM

matmarex set Security to None.

This is actually entirely fixed, as far as I can tell.

matmarex mentioned this in T51951: Window title for "Creating" should support parser functions.Apr 10 2015, 5:04 PM

The warning message is still there in the Firefox console:

mediawiki.jqueryMsg: some-key: Unknown operation "sometemplate"

That is a bug in calling code. Per comment T54479#547176 above, you should use mw.message( 'some-key' ).plain() if the message is supposed to include literal '{{', or escape the braces if you want it parsed (<nowiki/> probably won't work, but { probably will).

matmarex closed this task as Resolved.Apr 14 2015, 5:01 PM

He7d3r mentioned this in T44107: wikieditor-toolbar-help-content-signaturetimestamp-result: Parse error at position 19 in input:.Dec 21 2015, 11:39 PM

mw.msg should not return an error message if the message contains '{{SomeTemplate}}'Closed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

mw.msg should not return an error message if the message contains '{{SomeTemplate}}'
Closed, ResolvedPublic
Actions