Page MenuHomePhabricator

Upload Wizard not respecting default license of user
Closed, ResolvedPublic

Description

At some point recently, Upload Wizard stopped respecting the default license that the user sets in their user preferences. This is causing images to be uploaded with the wrong license.


Version: unspecified
Severity: critical

Details

Reference
bz52611

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 1:57 AM
bzimport added a project: UploadWizard.
bzimport set Reference to bz52611.

Specifically, when the user gets to the "Release rights" step, it seems to be applying the CC-BY-SA license regardless of what license the user has set as their default in their preferences.

The breakage happened sometime between July 15 and August 3.

mtraceur: Could you take a look at this?

Not in the near future, but it was Yuvi's patch, maybe he has a good idea of what went wrong?

Just got off vacation, and currently a bit sick. Should be able to in a day or two.

Hey Yuvi, did you ever get a chance to look at this?

Whoops, forgot about it and did other stuff. I'll be happy if someone else can, but if not I can hopefully look at this tomorrow?

I'm also surprised by the general lack of pitchforks and torches, considering this could be considered a big bug. But yes, tomorrow.

Change 81444 had a related patch set uploaded by MarkTraceur:
Fix bug in campaigns refactor for default licenses

https://gerrit.wikimedia.org/r/81444

Change 81444 merged by jenkins-bot:
Fix bug in campaigns refactor for default licenses

https://gerrit.wikimedia.org/r/81444

We "fixed" it, it seems to work now, but it won't get deployed for a little bit. I'm going to mark as resolved, but reopen if the patch doesn't fix it on Commons.

  • Bug 53574 has been marked as a duplicate of this bug. ***

Works for me when I tried it on betacommons. Marking as VERIFIED.