Page MenuHomePhabricator

VisualEditor: Links can point to wrong page if not matching case exactly and when not first option in the list
Closed, ResolvedPublic

Description

Author: sandrobt.wiki

Description:
Here is how to reproduce it, when trying to add a link to the page "Maria" on en.wiki.

  1. Select the add link icon and type "maria"
  2. Select "Maria", which is at the end of the suggested list
  3. Press Enter or the "<" button
  4. Save

The link is added to Mariah Carey (which was on the top of the suggested list).
Cf. https://en.wikipedia.org/w/index.php?title=User:Sandrobt/prova&diff=prev&oldid=567641122

Note that this doesn't happen if in 2) you had typed "Maria" (which is the exact title of the page you want to link to).
Cf. https://en.wikipedia.org/w/index.php?title=User:Sandrobt/prova&diff=next&oldid=567641169

The same problem appears in similar situations in it.wiki (for example when adding a link to "Sega" you need to type it exactly like that, since the first option is always SEGA)

I'm using Firefox 22.0 on Mac OS X 10.6.8.


Version: unspecified
Severity: normal

Details

Reference
bz52634

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:59 AM
bzimport set Reference to bz52634.

sandrobt.wiki wrote:

Ok, note taken. Though, a bug that inserts the wrong link in a pretty large variety of situation, despite selecting the correct one and without giving any clue of having done so, is a pretty seriuos problem and has probably alredy produced quite a lot of wrong wikilinks.

This happens in every case where:

  • the input text case INsensitively matches an entry >= 2nd in the list, AND
  • the input text case sensitively does NOT match the title of any in the list, AND
  • the user selects the case insensitive match

It doesn't matter whether the text was entered in the link dialog or selected on the editing surface.

In fixing bug 50452 we have changed the behaviour slightly regarding this - not sure if it's still necessary to keep this open?