Page MenuHomePhabricator

Alt+Shift+V access key in the wikitext editor switches to the visual one, so conflicts with 'show changes' which no longer works in Chrome, focus splits in Firefox
Open, LowPublic

Description

en.wp user JmCor reports that in Firefox on Windows 7 the shortcut "<shift><alt>V (show the changes), which stopped working when the Visual Editor was introduced: currently, <shift><alt>V simply positions the cursor on the "Show the changes" button."

I can confirm this also occurs in Firefox 23 on Linux.

Details

Reference
bz52701

Related Objects

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:04 AM
bzimport set Reference to bz52701.

Adding James to the CC as this might be an artefact of VE, even though it affects the source editor.

This is definitely related to VisualEditor - the shortcut works when VisualEditor is disabled (Safari on Mac 6, Firefox 23 on Linux) and in Konqueror on Linux which VE is not enabled for.

Changing component to VisualEditor accordingly

dng032 wrote:

(In reply to comment #2)

This is definitely related to VisualEditor - the shortcut works when
VisualEditor is disabled (Safari on Mac 6, Firefox 23 on Linux) and in
Konqueror on Linux which VE is not enabled for.

Changing component to VisualEditor accordingly

jmCor: still Windows 7, Firefox 22.0. The component change did not fix the bug on my machine.

This is because the same shortcut is used for multiple actions in the same page.

For me in Firefox in namespaces with visual editor enabled pressing alt+shift+v once focuses on the "show changes" button, pressing again focus on "visual edit" tab" and further key pressing just changes the focus between the two. In other namespaces focus is always on "show changes" button, but the shortcut does not actually click the button. That is because the HTML still contains a hidden "visual edit" tab with the same shortcut.

Suggestions for a different shortcut for VisualEditor (or show changes) welcome.

  • Bug 52969 has been marked as a duplicate of this bug. ***

Maybe Visual editor does not need an access key while the normal editor is used? Then one possible solution is to just remove 'v' as access key for visual editor when using the normal wiki editor.

I think removing the access key there should not cause any problems for most users, for two reasons:

  1. Since currently "show changes" in wiki editor has the same acces key, neither of the access keys work as they should.
  2. In most use cases for Visual editor a user starts visual editting when they are seeing an actual page, not when they are looking at the page in the wiki editor.

dng032 wrote:

Results of testing in Wikipedias about a week ago:

("Positions" means that focus changes to the "Show changes" button, but does not actually show the changes)

Catalan : positions
German : shows dif
French : positions
Greek : positions
English : shows dif
Spanish : shows dif
Hungarian : positions
Italian : warns about not saving
Japanese : shows dif
Portuguese : positions
Russian : positions
Simple English : positions
Chinese : shows dif

Sorry for being late to react and for not retesting recently. ~~~~

(In reply to Lejonel from comment #4)

In other namespaces focus is always on "show changes"
button, but the shortcut does not actually click the button. That is because
the HTML still contains a hidden "visual edit" tab with the same shortcut.

This is changing (bug 64142)

alt+shift+v appears to launch VE now we have editor switching (from duplicate T130899)

Yes Ed, but only when you're on the content page.

Jdforrester-WMF renamed this task from VisualEditor: Wikitext editor's keyboard shortcut for show changes (shift+alt+v) no longer works to Alt+Shift+V access key in the wikitext editor switches to the visual one, so conflicts with 'show changes' which no longer works in Chrome, focus splits in Firefox.May 30 2016, 6:05 PM
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF set Security to None.
Jdforrester-WMF added a subscriber: Krinkle.
Jdforrester-WMF added subscribers: Quiddity, Zppix.

Additionally https://www.mediawiki.org/wiki/Extension:FlaggedRevs add one more tab "Pending changes" which is also assigned "v" key. Any but unique replacement for short keys will be more convenient to activate instantly.

Would it be possible to just disable the VE accesskey if the wgAction is edit or submit?

What about using`E` as accesskey for visualEditor? From Read view, it opens wikitext editor. Pressing once again, it would switch to VisualEditor.

Tacsipacsi subscribed.

Additionally https://www.mediawiki.org/wiki/Extension:FlaggedRevs add one more tab "Pending changes" which is also assigned "v" key. Any but unique replacement for short keys will be more convenient to activate instantly.

See T335652: Duplicated access key ctrl-option-v (FlaggedRevs vs VisualEditor)

What about using`E` as accesskey for visualEditor? From Read view, it opens wikitext editor. Pressing once again, it would switch to VisualEditor.

I’d rather not change a conflicting access key to another conflicting one. The idea of @jhsoby seems better to me, although it doesn’t fix all conflicts either: filtering out edit and submit would fix this task, filtering out history would help fixing T26977, but there’s no way to fix T335652 with this approach, as both access keys should be available in read view.