Page MenuHomePhabricator

wblinktitles id in api response does not start with a q, it is a raw int id
Closed, ResolvedPublic

Description

When performing an action with linktitles the api reports back and ID but it doesn't come in the format 'q123' instead just '123'


Version: master
Severity: normal
Whiteboard: api_breaking_change

Details

Reference
bz52732

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:06 AM
bzimport set Reference to bz52732.
bzimport added a subscriber: Unknown Object (MLST).

Change 78521 had a related patch set uploaded by Addshore:
Refactor LinkTitlestest

https://gerrit.wikimedia.org/r/78521

(In reply to comment #1)

Change 78521 had a related patch set uploaded by Addshore:
Refactor LinkTitlestest

https://gerrit.wikimedia.org/r/78521

Patch was merged, is this fixed now?

The patch doesn't seem to actually touch the LinkTitles class so this is likely still open.

Also changing this will be a breaking change to the api output as anything currently using the module is probably expecting the id without a Q

Do we still need to do this then or should we resolve wontfix? The benefit is unclear to me.

We should still do this, although we should try and do it at the same time as other breaking changes.
The fix itself is only a line or two.

Change 138217 had a related patch set uploaded by Hoo man:
Make wblinktitles return a prefixed id

https://gerrit.wikimedia.org/r/138217

Change 138217 merged by Jeroen De Dauw:
Make wblinktitles return a prefixed id

https://gerrit.wikimedia.org/r/138217

Katie: Might need adding to deployment notes and possibly wider announcement?