Page MenuHomePhabricator

Regression: Wikitext for new lists has unnecessary newlines after bullets
Closed, ResolvedPublic

Description

Output after saving

My setup:

MediaWiki:
1.22alpha (ffa9b0a) 19:02, 11. Aug. 2013

VisualEditor (Version 0.1.0)(0e76b1b)20:01, 11. Aug. 2013

ParsoidServer:
commit a4fec47e5201c329925967376f4106abd11178e3
Merge: fdb6e06 30315ed Author: jenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Date: Fri Aug 9 02:43:12 2013 +0000

When I put in a simple Unsorted list the Parsoid Server throws an error message:
Incompatible constraints 1: LI P {a:{min: 0, max: 0}, b:{min: 1, max: 2}, min:0, max 0}

Attached you find the resulting output after I saved the page. Notice the extra Line that got added by Parsoid.


Version: unspecified
Severity: normal

Attached:

output_after_saving.png (255×353 px, 6 KB)

Details

Reference
bz52751

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:08 AM
bzimport added a project: Parsoid.
bzimport set Reference to bz52751.

I suspect this is a regression of some sort. Can be duplicated with this HTML below (VE wraps li-content in p-tags).

[subbu@earth tests] echo "<ul><li><p>a</p></li></ul>" | node parse --html2wt
Incompatible constraints 1: LI P { a: { min: 0, max: 0 }, b: { min: 1, max: 2 }, min: 0, max: 0 }

a

git bisect shows that c0de1d5839430e9fde79ff4195caf6841baab0d3 is the culprit. Will investigate and fix.

Change 78913 had a related patch set uploaded by Subramanya Sastry:
(Bug 52751): Serialize p-wrapped list items correctly

https://gerrit.wikimedia.org/r/78913

Change 78913 merged by jenkins-bot:
(Bug 52751): Serialize p-wrapped list items correctly

https://gerrit.wikimedia.org/r/78913