Page MenuHomePhabricator
Create Task
Maniphest T54762

Treat a line with WS and comments only as being transparent to all handlers
Closed, ResolvedPublic
Actions

Description

Bug 41756 fixed an old regression in the PHP preprocessor, so that a blank line containing nothing but two or more comments is ignored (does not break lists, etc).

This fix needs to be applied to Parsoid as well.

Version: unspecified
Severity: normal

Details

Reference
bz52762

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 2:08 AM
• bzimport added a project: Parsoid.
• bzimport set Reference to bz52762.
cscott created this task.Aug 12 2013, 6:49 PM
ssastry added a comment.Aug 12 2013, 8:08 PM

I am fixing the p-handler for now since it already had special-case code for the older pattern. But, a fix for 49974 would be more ideal that is more general.

ssastry added a comment.Aug 12 2013, 8:17 PM

Repurposing this bug for the general pattern. Will close 49974 as a dupe of this.

ssastry added a comment.Aug 12 2013, 8:17 PM
  • Bug 49974 has been marked as a duplicate of this bug. ***
gerritbot added a comment.Aug 12 2013, 8:20 PM

Change 78907 had a related patch set uploaded by Subramanya Sastry:
P-handler specific fix of bug 52762

https://gerrit.wikimedia.org/r/78907

gerritbot added a comment.Aug 13 2013, 7:41 PM

Change 78907 merged by jenkins-bot:
P-handler specific fix of bug 52762

https://gerrit.wikimedia.org/r/78907

gerritbot added a comment.Aug 26 2013, 4:53 PM

Change 81014 had a related patch set uploaded by Subramanya Sastry:
(Bug 52762) Lines with 1+ comments and WS are transparent to handlers

https://gerrit.wikimedia.org/r/81014

gerritbot added a comment.Aug 26 2013, 11:08 PM

Change 81014 merged by jenkins-bot:
(Bug 52762) Lines with 1+ comments and WS are transparent to handlers

https://gerrit.wikimedia.org/r/81014

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL