Page MenuHomePhabricator
Create Task
Maniphest T7278

Self-including templates should reflect changes on preview
Closed, ResolvedPublic
Actions

Assigned To
Jackmcbarn
Authored By
• bzimport
Mar 17 2006, 4:56 PM
Tags
Referenced Files
F2695: PATCH.template_preview
Nov 21 2014, 9:10 PM
Subscribers
AzaToth
• GWicke
Jackmcbarn
Ltrlg
TheDJ
• wikibugs-l-list
Tokens
"Haypence" token, awarded by RandomDSdevel."Love" token, awarded by Ciencia_Al_Poder.

Description

Author: p.r.doyle+mediazilla

Description:
This is a feature request.

Templates sometimes include an example of their own usage inside <noinclude>
tags. It would be nice if previewing a change to such a template would reflect
the changes. In fact, as far as I know, there is currently no way to preview
the effect of a template aside from (1) submitting it, (2) picking a page that
includes it, (3) doing a null edit on said page, and (4) inspecting said page.

This suggestion would provide a way to preview template changes before they go
"live".

Version: unspecified
Severity: normal
URL: http://en.wikipedia.org/wiki/Template:NLL_Team_Infobox

Details

Reference
bz5278
SubjectRepoBranchLines +/-
Use preview content when it transcludes itselfmediawiki/coremaster+44 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 21 2014, 9:10 PM
• bzimport added a project: MediaWiki-Templates.
• bzimport set Reference to bz5278.
• bzimport added a subscriber: Unknown Object (MLST).
• bzimport created this task.Mar 17 2006, 4:56 PM
• brion added a comment.Mar 17 2006, 7:52 PM

There's no such thing as "self-including templates". If it appears to work, that's a bug.

• bzimport added a comment.Mar 17 2006, 9:02 PM

p.r.doyle+mediazilla wrote:

Why not? It's in a <noinclude>. Seems reasonable to me.

• bzimport added a comment.Apr 1 2006, 11:07 PM

robchur wrote:

At the point of previewing, the template changes aren't saved in the database,
so the transclusion processor doesn't know about them, hence can't render them.

• bzimport added a comment.Apr 2 2006, 2:39 AM

p.r.doyle+mediazilla wrote:

Ok, thanks. That explains why it currently doesn't work. Can the transclusion
processor be given access to the text of the page being previewed? That
probably requires some interface changes, but it may be worthwhile if it allows
templates to be previewed.

• brion added a comment.Apr 2 2006, 3:08 AM

Self-inclusion would violate the recursion checks; once that bug is fixed there
would be nothing to show. Resolving INVALID.

• bzimport added a comment.Apr 2 2006, 5:06 PM

p.r.doyle+mediazilla wrote:

Brion, I'm finding your approach to this bug very frustrating. If you're going
to keep closing this bug, can you at least explain why you think this feature
should be disallowed?

• brion added a comment.Apr 2 2006, 7:12 PM

Recursive inclusions are disallowed as a standard protection against loops.

IAlex added a comment.Sep 21 2009, 4:58 PM
  • Bug 11367 has been marked as a duplicate of this bug. ***
• bzimport added a comment.Sep 21 2009, 5:08 PM

p.r.doyle wrote:

Recursive inclusions inside <noinclude> can't cause loops.

IAlex added a comment.Feb 1 2010, 4:05 PM
  • Bug 22341 has been marked as a duplicate of this bug. ***
• bzimport added a comment.Jun 10 2010, 12:11 PM

conrad.irwin wrote:

Patch for rendering

This patch adds short-circuits to ParserOptions::mTemplateCallback during the parse() phase of preview, save, and parserTests (bug 8158), which includes the current text of the page instead of the previous revision from the database.

This means that it won't change the behaviour of {{subst:, which continues to use the previous page's revision, and any extensions that deal with the current version of the current article will not be able to see the pending revision (as who knows what they might do).

Is this approach the right way to do things, and, if so, is this patch sufficient?

Attached:

PATCH.template_preview8 KBDownload

• bzimport added a comment.Aug 17 2012, 10:48 AM

sumanah wrote:

Adding Derk-Jan & Gabriel to cc so they can comment on this patch.

Anomie added a comment.Apr 15 2014, 6:39 PM
  • Bug 63944 has been marked as a duplicate of this bug. ***
gerritbot added a comment.Jun 3 2014, 8:14 PM

Change 137153 had a related patch set uploaded by Jackmcbarn:
Use preview content when it transcludes itself

https://gerrit.wikimedia.org/r/137153

Jackmcbarn mentioned this in T85408: ifexist: when creating a page.Dec 28 2014, 4:44 PM
gerritbot added a comment.Dec 30 2014, 5:59 PM

Change 137153 had a related patch set uploaded (by Jackmcbarn):
Use preview content when it transcludes itself

https://gerrit.wikimedia.org/r/137153

Patch-For-Review

gerritbot added a comment.Dec 31 2014, 4:19 PM

Change 137153 merged by jenkins-bot:
Use preview content when it transcludes itself

https://gerrit.wikimedia.org/r/137153

Jackmcbarn mentioned this in rMW779f1024c102: Use preview content when it transcludes itself.Dec 31 2014, 4:19 PM
Ciencia_Al_Poder awarded a token.Dec 31 2014, 4:26 PM
Jackmcbarn closed this task as Resolved.Dec 31 2014, 5:28 PM
Jackmcbarn claimed this task.

The fix will be live on all WMF wikis on January 14th.

RandomDSdevel awarded a token.Jan 12 2015, 11:28 PM
Anomie mentioned this in T119827: protectionLevels says that the current title is protected if it does not exist.Nov 30 2015, 5:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL