Page MenuHomePhabricator

VisualEditor: FlaggedRevs inserts its tabs in the midst of the edit and edit source tabs
Closed, ResolvedPublic

Description

Screenshot

On wikis with FlaggedRevs, the interface historically displays buttons in the order [edit][pending changes]. This seems logical.

Under the VE (screenshot attached) it goes [edit][pending changes][edit source]. This doesn't ;p. Restoring the previous setup (so that it would show as [edit][edit source][pending changes]) would be good.


Version: unspecified
Severity: normal

Attached:

Bug.png (131×1 px, 21 KB)

Details

Reference
bz52848

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:45 AM
bzimport set Reference to bz52848.

For me it shows [pending changes][edit] without VE (and the comments indicate this is the intended behaviur), so I think with VE should be [pending changes][edit][edit source].

Change 110862 had a related patch set uploaded by Alex Monk:
Don't try to insert the pending changes in the middle of VE's 'Edit' and 'Edit source'

https://gerrit.wikimedia.org/r/110862

Change 110862 merged by Catrope:
Don't try to insert the pending changes in the middle of VE's 'Edit' and 'Edit source'

https://gerrit.wikimedia.org/r/110862