Page MenuHomePhabricator

Call to a member function getContent() on a non-object
Closed, ResolvedPublic

Description

Author: sumanah

Description:
About fifteen minutes ago, I was trying to save a new page on test2wiki ([[Blooper]]) and got a general "the site is down, sorry, signed, WMF" error page. The error msg was:

PHP fatal error in /usr/local/apache/common-local/php-1.22wmf13/extensions/CirrusSearch/CirrusSearch.body.php line 400
Call to a member function getContent() on a non-object

I then tried hitting back and Save again, and it saved just fine. But Chad's also run into this: "Pretty sure I know the problem & fix, but good to track." So here you go Chad. :-)


Version: unspecified
Severity: major

Details

Reference
bz52907

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 1:49 AM
bzimport added a project: CirrusSearch.
bzimport set Reference to bz52907.

Setting as high priority and asigning to Chad as he seems to know what this is already.

Change 79346 had a related patch set uploaded by Demon:
Fix fatal error when revision data isn't loaded properly

https://gerrit.wikimedia.org/r/79346

Change 79346 merged by jenkins-bot:
Fix fatal error when revision data isn't loaded properly

https://gerrit.wikimedia.org/r/79346

Grr, haven't nailed this down for sure, REOPENING.

sumanah wrote:

Just got it again when trying to upload a file, but the line number changed:

PHP fatal error in /usr/local/apache/common-local/php-1.22wmf13/extensions/CirrusSearch/CirrusSearch.body.php line 407:
Call to a member function getContent() on a non-object

sumanah wrote:

(And now https://test2.wikipedia.org/wiki/File:Savepage-greyed.png is mentioned in my uploads at https://test2.wikipedia.org/w/index.php?title=Special:MyUploads and the file summary has been added, but the file itself doesn't exist - "No file by this name exists, but you can upload it.")

[19-Aug-2013 20:39:18] Fatal error: Call to a member function getContent() on a non-object at /usr/local/apache/common-local/php-1.22wmf13/extensions/CirrusSearch/CirrusSearch.body.php on line 407
Server: mw1142
Method: POST
URL: http://test2.wikipedia.org/w/api.php
Backtrace:
#0 /usr/local/apache/common-local/php-1.22wmf13/extensions/CirrusSearch/CirrusSearch.body.php(407): CirrusSearch::linksUpdateCompletedHook()
#1 [internal function]: CirrusSearch::linksUpdateCompletedHook(Object(LinksUpdate))
#2 /usr/local/apache/common-local/php-1.22wmf13/includes/Hooks.php(199): call_user_func_array('CirrusSearch::l...', Array)
#3 /usr/local/apache/common-local/php-1.22wmf13/includes/GlobalFunctions.php(3851): Hooks::run('LinksUpdateComp...', Array)
#4 /usr/local/apache/common-local/php-1.22wmf13/includes/LinksUpdate.php(123): wfRunHooks('LinksUpdateComp...', Array)
#5 /usr/local/apache/common-local/php-1.22wmf13/includes/DataUpdate.php(102): LinksUpdate->doUpdate()
#6 /usr/local/apache/common-local/php-1.22wmf13/includes/WikiPage.php(2077): DataUpdate::runUpdates(Array)
#7 /usr/local/apache/common-local/php-1.22wmf13/includes/WikiPage.php(1911): WikiPage->doEditUpdates(Object(Revision), Object(User), Array)
#8 /usr/local/apache/common-local/php-1.22wmf13/includes/filerepo/file/LocalFile.php(1349): WikiPage->doEditContent(Object(WikitextContent), 'User created pa...', 9, false, Object(User))
#9 /usr/local/apache/common-local/php-1.22wmf13/includes/filerepo/file/LocalFile.php(1111): LocalFile->recordUpload2('', 'User created pa...', '=={{int:filedes...', Array, false, Object(User))
#10 /usr/local/apache/common-local/php-1.22wmf13/includes/upload/UploadBase.php(687): LocalFile->upload('/tmp/localcopy_...', 'User created pa...', '=={{int:filedes...', 1, Array, false, Object(User))
#11 /usr/local/apache/common-local/php-1.22wmf13/includes/upload/UploadFromStash.php(182): UploadBase->performUpload('User created pa...', '=={{int:filedes...', true, Object(User))
#12 /usr/local/apache/common-local/php-1.22wmf13/includes/api/ApiUpload.php(627): UploadFromStash->performUpload('User created pa...', '=={{int:filedes...', true, Object(User))
#13 /usr/local/apache/common-local/php-1.22wmf13/includes/api/ApiUpload.php(146): ApiUpload->performUpload(Array)
#14 /usr/local/apache/common-local/php-1.22wmf13/includes/api/ApiUpload.php(114): ApiUpload->getContextResult()
#15 /usr/local/apache/common-local/php-1.22wmf13/includes/api/ApiMain.php(840): ApiUpload->execute()
#16 /usr/local/apache/common-local/php-1.22wmf13/includes/api/ApiMain.php(380): ApiMain->executeAction()
#17 /usr/local/apache/common-local/php-1.22wmf13/includes/api/ApiMain.php(351): ApiMain->executeActionWithErrorHandling()
#18 /usr/local/apache/common-local/php-1.22wmf13/api.php(73): ApiMain->execute()
#19 /usr/local/apache/common-local/w/api.php(3): require('/usr/local/apac...')

Change 79920 had a related patch set uploaded by Reedy:
When we create a new revision object, we should assign it to something

https://gerrit.wikimedia.org/r/79920

Change 79920 merged by jenkins-bot:
When we create a new revision object, we should assign it to something

https://gerrit.wikimedia.org/r/79920

Deployed and no longer seeing errors.