Page MenuHomePhabricator

Tabs do not cause indent-pres, only spaces do
Closed, ResolvedPublic

Description

See https://gerrit.wikimedia.org/r/#/c/79341/

Parsoid currently treats tabs like spaces when it comes to indent-pres.


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=56195

Details

Reference
bz52938

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:51 AM
bzimport set Reference to bz52938.

http://parsoid.wmflabs.org/pl/Wikipedia:Strona_g%C5%82%C3%B3wna does look somewhat preformatted. Too bad that this inconsistency is exploited. Would be tempting to fix it otherwise.

I doubt it's exploited widely, but it does sometimes make the code cleaner when using complicated markup, such as on that main page.

Removing the tabs there would be easy and I can do that; I remember being surprised that this worked when I wrote it.

We should get some stats, but I'd be surprised if it affects any other page on any wiki.

Change 92364 had a related patch set uploaded by GWicke:
Bug 52938: Don't trigger indent pre on tabs

https://gerrit.wikimedia.org/r/92364

Change 92364 merged by jenkins-bot:
Bug 52938: Only trigger indent pre on spaces

https://gerrit.wikimedia.org/r/92364